From owner-freebsd-wireless@freebsd.org Sun Oct 1 10:33:35 2017 Return-Path: Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 39810E0F8D4 for ; Sun, 1 Oct 2017 10:33:35 +0000 (UTC) (envelope-from s3erios@gmail.com) Received: from mail-wm0-x22e.google.com (mail-wm0-x22e.google.com [IPv6:2a00:1450:400c:c09::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C14B8813DE for ; Sun, 1 Oct 2017 10:33:34 +0000 (UTC) (envelope-from s3erios@gmail.com) Received: by mail-wm0-x22e.google.com with SMTP id e195so1985977wma.5 for ; Sun, 01 Oct 2017 03:33:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=to:subject:references:date:cc:mime-version :content-transfer-encoding:from:message-id:in-reply-to:user-agent; bh=2/2gFJ1lyO3gI5NMyPXM+FoqrHXZL3vW7UAy16dRT/w=; b=CeN6waqLj6EuiFMAz4I24BU6G50OTsnOQ6DsWcJhg3M1wxKqF65TeoWk4fYunjE3FC J4S3f4EA/kDImOmt9RmUYyckv/72yIrfm671wxV4ZA+etpmGbqQCha1AoR0LW3yfkQj4 sMzo9cZ0Ir/5AHKPeUYaZjptDyy/940PdjUJbq/TnmC9K4JqRyyaugZNF/5/zTw9THOS PoiCDH6eBhNP9QogysrzetNRDYGkT5hSGjc5QrjVHtJ73S/X1O6N03gqrLwYq/7bEFtW pIUKURmmsnRnrQAEmrb+GlE4NrDuNSnRt+pf3tJqX3wf1jx4RUPOUwOYsaWqGV7eJvMz 8oMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:to:subject:references:date:cc:mime-version :content-transfer-encoding:from:message-id:in-reply-to:user-agent; bh=2/2gFJ1lyO3gI5NMyPXM+FoqrHXZL3vW7UAy16dRT/w=; b=ahc0dRFy7cw6rdCbO3z5DX3ej6vWRShHqIk5qXDFCV+15fNZB1gQ4I10h1cEz0orKy ZqRiUVoOYco96FpbSK+PbEKFlNbZduUUDd8tTBa4N3KQi2wk8MIhi+4fmG4isLo1UpG3 z+6nXTiizOJYgi4r7M2r04w6vjSLALLwC4zGYTtWhcN335rR0i5F1L71ODa1/HJV/nue /jZH0ay0nXKRn/jqrweAhFrSOGP1Z1vQj3SbGYK7wUbIxT6HIOSNpQPetgciSOuFf3Sw sJgYFoiPGXr/cECR/4AK75a6gguV6rbOI23Wyxp3WlkgSlLDfFV+n45llArgcUvrC68B vndQ== X-Gm-Message-State: AHPjjUie0gakIiHp0HMf61GZBJ/6vLR4lJUL4PMItMoSiSiPT4FUbugP iHsF8TkcQgqw7O2Oycsn5T0= X-Google-Smtp-Source: AOwi7QDQDfnXEoznyHr4ZMjmpHF0EvjS0U5bvvDynv5TwgYg6k6lld8vkxKIgq+fILh7yFHQZywQIA== X-Received: by 10.28.247.19 with SMTP id v19mr869293wmh.1.1506854012890; Sun, 01 Oct 2017 03:33:32 -0700 (PDT) Received: from thinkpad-x220 (46-133-43-27.dialup.umc.net.ua. [46.133.43.27]) by smtp.gmail.com with ESMTPSA id x75sm10630372wme.3.2017.10.01.03.33.25 (version=TLS1 cipher=AES128-SHA bits=128/128); Sun, 01 Oct 2017 03:33:32 -0700 (PDT) Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: "Farhan Khan" Subject: Re: Register Address Size Mismatch References: <293228d3-c777-d928-8476-ee23ba487c72@gmail.com> Date: Sun, 01 Oct 2017 13:30:47 +0300 Cc: freebsd-wireless@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: "Andriy Voskoboinyk" Message-ID: In-Reply-To: <293228d3-c777-d928-8476-ee23ba487c72@gmail.com> User-Agent: Opera Mail/12.15 (FreeBSD) X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Oct 2017 10:33:35 -0000 Hi, RF registers are using indirect addressing; you should use rtwn_rf_write() / rtwn_rf_read() instead. > I am working on porting over a Linux Realtek driver to FreeBSD. I ran > into a register-size issue. > > FreeBSD's PCI-write function is defined as follows: > rtwn_pci_write_4(struct rtwn_softc *sc, uint16_t addr) > > Notice that the second parameter is of type uint16_t. > > During initialization, the rtwn driver uses the rtwn_rf_prog structure > to write a pre-defined list of data to a pre-defined list of registers. > The structure to hold both lists is defined here: > http://src.illumos.org/source/xref/freebsd-head/sys/dev/rtwn/if_rtwnreg.h#150. > Notice how the second parameter 'reg' is a uint8_t. > > The rtwn_pci_write_4's addr is uint16_t, the rtwn_rf_prog's addr is a > uint8_t. How would I reconcile this type mismatch? Additionally, the > Linux version of this block of code has all register values as a > uint32_t. It is not a matter of a cast, because some values definitely > use more than 1 byte (ie 0xFFE). > > Suggestions on how to reconcile and resolve this issue? > > Thanks! > Farhan Khan > _______________________________________________ > freebsd-wireless@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-wireless > To unsubscribe, send any mail to > "freebsd-wireless-unsubscribe@freebsd.org"