From owner-freebsd-ports@FreeBSD.ORG Fri Nov 21 11:09:48 2014 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5DB353FE for ; Fri, 21 Nov 2014 11:09:48 +0000 (UTC) Received: from smtprelay01.ispgateway.de (smtprelay01.ispgateway.de [80.67.29.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E3D3AEA9 for ; Fri, 21 Nov 2014 11:09:47 +0000 (UTC) Received: from [78.35.134.216] (helo=fabiankeil.de) by smtprelay01.ispgateway.de with esmtpsa (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.84) (envelope-from ) id 1Xrlnu-0004aS-D5; Fri, 21 Nov 2014 11:51:06 +0100 Date: Fri, 21 Nov 2014 11:51:08 +0100 From: Fabian Keil To: freebsd-ports@freebsd.org Cc: freebsd-ports@freebsd.org Subject: Re: Request for (i386) testing: american fuzzy lop Message-ID: <1557502e.1751489a@fabiankeil.de> In-Reply-To: References: <3dc1c153.7b7b9177@fabiankeil.de> <546DF8A5.3060601@gmail.com> <3fb914c3.1002708a@fabiankeil.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/KvgEBbXwaW2s20ls+21=PSW"; protocol="application/pgp-signature" X-Df-Sender: Nzc1MDY3 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Nov 2014 11:09:48 -0000 --Sig_/KvgEBbXwaW2s20ls+21=PSW Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Jan Beich wrote: > Fabian Keil writes: >=20 > > Vitaly Magerya wrote: > >> I don't know what this part is supposed to do: > >>=20 > >> # Workaround to make sure clang isn't confused for gcc > >> CC=3D${COMPILER_TYPE} > >>=20 > >> ... but it seems to set CC to empty string on my machine; and I > >> get a whole bunch of this as the result: > > > > Interesting. > > > > It was supposed to set CC for gmake to either clang or gcc, > > otherwise a cc that is clang is treated as gcc. > > > > However clobbering CC directly is obviously wrong and on > > systems where cc is still gcc, the workaround shouldn't > > be necessary anyway. > > > > Does it work for you if you replace the line with: > > MAKE_ARGS+=3D CC=3D${COMPILER_TYPE} > > ? >=20 > USE_GCC becomes a nop while setting explicitly fails >=20 > $ uname -rp > 11.0-CURRENT amd64 >=20 > $ echo CC=3Dgcc49 >>/etc/.make.conf > $ make > ... > =3D=3D=3D> Building for afl-0.60b > gmake[2]: Entering directory '/work/afl-0.60b' > [*] Checking for the ability to compile x86 code... > [+] All done! Be sure to review README - it's pretty short and useful. > gcc: not found >=20 > Why not patch the vendor Makefile? Here're my changes: >=20 > - use $(CC) --version to detect clang > - remove -g from CFLAGS (see WITH_DEBUG) > - strip(1) binaries during install > - global TESTing with generic option name Thanks a lot for the patch. The CC detection has already been fixed upstream, but I took the rest of the changes with the exception of renaming TEST_INSTRUMENTATION to TEST (I think it's overloaded already, just like DOCS). =20 > while poudriere caught Clang i386 failing >=20 > [*] Testing the CC wrapper and instrumentation output... > AFL_QUIET=3D1 AFL_INST_RATIO=3D100 AFL_PATH=3D. ./afl-clang -O2 -pipe = -fstack-protector -fno-strict-aliasing -Wall -D_FORTIFY_SOURCE=3D2 -Wno-poi= nter-sign -DAFL_PATH=3D\"/prefix/afl-0.60b/lib/afl\" -DDOC_PATH=3D\"/prefix= /afl-0.60b/share/doc/afl\" -DVERSION=3D\"0.60b\" -Wno-format test-instr.c -= o test-instr > /tmp/.afl-19244-1416499444.s: Assembler messages: > /tmp/.afl-19244-1416499444.s:222: Error: unknown pseudo-op: `.cfi_secti= ons' > clang: error: assembler command failed with exit code 1 (use -v to see = invocation) I updated the port to (hopefully) use as from ports on i386: http://www.fabiankeil.de/sourcecode/freebsd/afl-61b.shar Does this make a difference? If not, I'll probably just submit the port marked as broken for i386 and try to get this working later on. Fabian --Sig_/KvgEBbXwaW2s20ls+21=PSW Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlRvGRwACgkQBYqIVf93VJ2BrwCeL3x/7jjGhT8PaVflPu0Kl602 IzsAoK1EzSdRMHY3UYCNWYzLXtK60v9R =Y9qp -----END PGP SIGNATURE----- --Sig_/KvgEBbXwaW2s20ls+21=PSW--