Date: Sat, 10 Nov 2018 06:07:12 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Jan Beich <jbeich@freebsd.org> Cc: Tobias Kortkamp <tobik@freebsd.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r484222 - in head/mail/libdomainkeys: . files Message-ID: <20181110060711.GB79182@FreeBSD.org> In-Reply-To: <r2fw-equx-wny@FreeBSD.org> References: <201811052109.wA5L9f22029571@repo.freebsd.org> <20181106134950.GA12772@FreeBSD.org> <1541536096.2238291.1567906016.21263D52@webmail.messagingengine.com> <20181107165059.GA97864@FreeBSD.org> <r2fw-equx-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 07, 2018 at 06:31:50PM +0100, Jan Beich wrote: > Alexey Dokuchaev <danfe@freebsd.org> writes: > > On Tue, Nov 06, 2018 at 09:28:16PM +0100, Tobias Kortkamp wrote: > >> On Tue, Nov 6, 2018, at 14:49, Alexey Dokuchaev wrote: > >> > On Mon, Nov 05, 2018 at 09:09:41PM +0000, Tobias Kortkamp wrote: > >> > > New Revision: 484222 > >> > > URL: https://svnweb.freebsd.org/changeset/ports/484222 > >> > > > >> > > Log: > >> > > mail/libdomainkeys: Unbreak with OpenSSL 1.1.1 [1] > >> > > > >> > > ++#if OPENSSL_VERSION_NUMBER < 0x1010000fL > >> > > >> > I think this should be 0x10100005L instead; ditto below. > >> > >> Why? > > > > I recall that API opaqueness changes were first introduced in 1.1.0-pre5 > > (hence 0x10100005L), but got lost in their GitHub mirror to provide you > > with exact evidence link (git is just atrocious for code archaeology). > > Did you mean https://github.com/openssl/openssl/commit/7638370ca6cb ? > > $ git describe --contains 7638370ca6cb > OpenSSL_1_1_0-pre1~120 > > $ git grep 'define.*OPENSSL_VERSION_NUMBER' OpenSSL_1_1_0-pre1 \*.h > OpenSSL_1_1_0-pre1:include/openssl/opensslv.h:# define OPENSSL_VERSION_NUMBER 0x10100001L Oh, now I'm even more confused. I've seen 0x10100005L referenced several times in various patches; I guess I'd have to clone that OpenSSL repo and see for myself. On the other hand, if it turns out that not all API changes that affect consumers' builds fall under the same OPENSSL_VERSION_NUMBER then perhaps it does not make much sense to try to pinpoint the check to a particular version number after all... :-/ ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181110060711.GB79182>