Date: Wed, 22 Oct 2008 11:31:58 -0400 From: Jung-uk Kim <jkim@FreeBSD.org> To: Kostik Belousov <kostikbel@gmail.com> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, "Andrey A. Chernov" <ache@FreeBSD.org> Subject: Re: svn commit: r184161 - head/sys/i386/i386 Message-ID: <200810221132.02162.jkim@FreeBSD.org> In-Reply-To: <20081022150452.GD94031@deviant.kiev.zoral.com.ua> References: <200810221445.m9MEjUcq031169@svn.freebsd.org> <20081022150452.GD94031@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 22 October 2008 11:04 am, Kostik Belousov wrote: > On Wed, Oct 22, 2008 at 02:45:30PM +0000, Andrey A. Chernov wrote: > > Author: ache > > Date: Wed Oct 22 14:45:30 2008 > > New Revision: 184161 > > URL: http://svn.freebsd.org/changeset/base/184161 > > > > Log: > > Fix compiler error with missing/unneded ')' > > > > Modified: > > head/sys/i386/i386/identcpu.c > > > > Modified: head/sys/i386/i386/identcpu.c > > ================================================================= > >============= --- head/sys/i386/i386/identcpu.c Wed Oct 22 > > 10:12:21 2008 (r184160) +++ head/sys/i386/i386/identcpu.c Wed Oct > > 22 14:45:30 2008 (r184161) @@ -842,9 +842,9 @@ printcpuinfo(void) > > cpu_feature &= ~CPUID_HTT; > > > > if (!tsc_is_invariant && > > - (strcmp(cpu_vendor, "AuthenticAMD") == 0 && > > - (amd_pminfo & AMDPM_TSC_INVARIANT) != 0 || > > - I386_CPU_FAMILY(cpu_id) >= 0x10))) { > > + ((strcmp(cpu_vendor, "AuthenticAMD") == 0 && > > + (amd_pminfo & AMDPM_TSC_INVARIANT) != 0) || > > + I386_CPU_FAMILY(cpu_id) >= 0x10)) { > > tsc_is_invariant = 1; > > printf("\n P-state invariant TSC"); > > } > > Taking apart commit message, I think you change is wrong > semantically. Checking CPU_FAMILY without first checking vendor is > meaningless. Correct. Please do not touch this part cause I am going to fix it and add more quirks. Sorry for the breakage. Jung-uk Kim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200810221132.02162.jkim>