Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 11 Jul 2006 12:48:01 GMT
From:      Paolo Pisati <piso@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 101270 for review
Message-ID:  <200607111248.k6BCm12F033357@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=101270

Change 101270 by piso@piso_newluxor on 2006/07/11 12:47:59

	Unbreak FAST handlers: with filters in place, it's legal
	to have handler == NULL, while it's not correct to have
	both filter == NULL && handler == NULL.
	
	This fixes all the problems i had with my laptop, and now 
	i've 2 boxes (my laptop and my desktop) happily running this 
	branch with no problem: the basic infrastructure is ready now
	to accept filter+ithread drivers.

Affected files ...

.. //depot/projects/soc2006/intr_filter/kern/kern_intr.c#7 edit

Differences ...

==== //depot/projects/soc2006/intr_filter/kern/kern_intr.c#7 (text+ko) ====

@@ -329,7 +329,7 @@
 	struct intr_handler *ih, *temp_ih;
 	struct intr_thread *it;
 
-	if (ie == NULL || name == NULL || handler == NULL)
+	if (ie == NULL || name == NULL || (handler == NULL && filter == NULL))
 		return (EINVAL);
 
 	/* Allocate and populate an interrupt handler structure. */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200607111248.k6BCm12F033357>