From owner-p4-projects@FreeBSD.ORG  Tue Jul 11 12:48:02 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 891A816A4DF; Tue, 11 Jul 2006 12:48:02 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4C18A16A4DA
	for <perforce@freebsd.org>; Tue, 11 Jul 2006 12:48:02 +0000 (UTC)
	(envelope-from piso@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0225143D4C
	for <perforce@freebsd.org>; Tue, 11 Jul 2006 12:48:02 +0000 (GMT)
	(envelope-from piso@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6BCm1gF033360
	for <perforce@freebsd.org>; Tue, 11 Jul 2006 12:48:01 GMT
	(envelope-from piso@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6BCm12F033357
	for perforce@freebsd.org; Tue, 11 Jul 2006 12:48:01 GMT
	(envelope-from piso@freebsd.org)
Date: Tue, 11 Jul 2006 12:48:01 GMT
Message-Id: <200607111248.k6BCm12F033357@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	piso@freebsd.org using -f
From: Paolo Pisati <piso@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 101270 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Jul 2006 12:48:02 -0000

http://perforce.freebsd.org/chv.cgi?CH=101270

Change 101270 by piso@piso_newluxor on 2006/07/11 12:47:59

	Unbreak FAST handlers: with filters in place, it's legal
	to have handler == NULL, while it's not correct to have
	both filter == NULL && handler == NULL.
	
	This fixes all the problems i had with my laptop, and now 
	i've 2 boxes (my laptop and my desktop) happily running this 
	branch with no problem: the basic infrastructure is ready now
	to accept filter+ithread drivers.

Affected files ...

.. //depot/projects/soc2006/intr_filter/kern/kern_intr.c#7 edit

Differences ...

==== //depot/projects/soc2006/intr_filter/kern/kern_intr.c#7 (text+ko) ====

@@ -329,7 +329,7 @@
 	struct intr_handler *ih, *temp_ih;
 	struct intr_thread *it;
 
-	if (ie == NULL || name == NULL || handler == NULL)
+	if (ie == NULL || name == NULL || (handler == NULL && filter == NULL))
 		return (EINVAL);
 
 	/* Allocate and populate an interrupt handler structure. */