Date: Fri, 11 Jan 2008 09:26:03 -0500 (EST) From: "John Baldwin" <jhb@FreeBSD.org> To: "Konstantin Belousov" <kib@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/fdc fdc.c Message-ID: <59750.192.168.0.18.1200061563.squirrel@mail.baldwin.cx> In-Reply-To: <200801111153.m0BBr4Ho032590@repoman.freebsd.org> References: <200801111153.m0BBr4Ho032590@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, January 11, 2008 6:53 am, Konstantin Belousov wrote: > kib 2008-01-11 11:53:04 UTC > > FreeBSD src repository > > Modified files: > sys/dev/fdc fdc.c > Log: > Fix unload of the fdc.ko: > > Wakeup the thread doing the fdc_detach() when the fdc worker thread > exits [1]. > Write access to the write-protected floppy shall call device_unbusy() to > pair the device_busy() in the fd_access() [2]. > > PR: 116537 [1], 116539 [2] > MFC after: 1 week > > Revision Changes Path > 1.319 +8 -1 src/sys/dev/fdc/fdc.c [1] is wrong and reintroduces a panic race on module unload. The wakeup() is internal to kproc_exit/kthread_exit. The correct fix is to fix the msleep() in detach to sleep on fdc->fdc_thread instead of &fdc->fdc_thread. -- John Baldwin <jhb@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?59750.192.168.0.18.1200061563.squirrel>