Date: Tue, 14 Oct 2008 16:49:04 +0200 From: Max Laier <max@love2party.net> To: Roman Kurakin <rik@inse.ru> Cc: Maxim Konovalov <maxim@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r183881 - head/sys/netinet Message-ID: <200810141649.04834.max@love2party.net> In-Reply-To: <48F4A9A5.8020605@inse.ru> References: <200810141226.m9ECQtPW006469@svn.freebsd.org> <48F4A9A5.8020605@inse.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 14 October 2008 16:16:05 Roman Kurakin wrote: > Maxim Konovalov: > > Author: maxim > > Date: Tue Oct 14 12:26:55 2008 > > New Revision: 183881 > > URL: http://svn.freebsd.org/changeset/base/183881 > > > > Log: > > o Reformat ipfw nat get|setsockopt code to look it more > > style(9) compliant. No functional changes. > > > > Modified: > > head/sys/netinet/ip_fw2.c > > > > Modified: head/sys/netinet/ip_fw2.c > > ========================================================================= > >===== --- head/sys/netinet/ip_fw2.c Tue Oct 14 10:23:11 2008 (r183880) +++ > > head/sys/netinet/ip_fw2.c Tue Oct 14 12:26:55 2008 (r183881) @@ -4385,49 > > +4385,52 @@ ipfw_ctl(struct sockopt *sopt) > > break; > > > > case IP_FW_NAT_CFG: > > - { > > - if (IPFW_NAT_LOADED) > > - error = ipfw_nat_cfg_ptr(sopt); > > - else { > > - printf("IP_FW_NAT_CFG: ipfw_nat not present, please load it.\n"); > > - error = EINVAL; > > + { > > + if (IPFW_NAT_LOADED) > > + error = ipfw_nat_cfg_ptr(sopt); > > + else { > > + printf("IP_FW_NAT_CFG: %s\n", > > + "ipfw_nat not present, please load it"); > > + error = EINVAL; > > + } > > } > > IMHO such indention does not add any usefulness, but increases indention > level that is already very high. > Also I do not see strict contradiction to the style(9), but probably I > am not reading the most current style(9). The additional scope is absolutely unnecessary here and should be dropped - IMHO. See case IP_FW_RESETLOG and above. -- /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200810141649.04834.max>