Date: Mon, 22 Aug 2005 21:32:21 +0000 From: "Wojciech A. Koszek" <dunstan@freebsd.czest.pl> To: John Baldwin <jhb@FreeBSD.org> Cc: freebsd-current@FreeBSD.org Subject: Re: Locking for ef(4) Message-ID: <20050822213221.GA22155@freebsd.czest.pl> In-Reply-To: <200508221600.07740.jhb@FreeBSD.org> References: <20050820192601.GA945@freebsd.czest.pl> <200508221600.07740.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Aug 22, 2005 at 04:00:06PM -0400, John Baldwin wrote: > On Saturday 20 August 2005 03:26 pm, Wojciech A. Koszek wrote: > > Hello, [..] > > You might want to consider using MTX_SYSINIT() to initialize your mutex > instead of manually doing it in your module handler routine. Either that or > go ahead and push the calls to mtx_init() and mtx_destroy() into ef_load() > and ef_unload() so all the load stuff happens in one function, etc. I've moved mtx_init and mtx_destroy to ef_load() and ef_unload(). > Might also want to check for whitespace breakage in your diffs. In > ef_detach() you replaced the empty line before ether_ifdetach() with a line > that contains just a tab. Fixed. I've also removed also other place with redundant tabs. Updated patch: http://freebsd.czest.pl/dunstan/FreeBSD/diff.1.locking.if_ef.c Thanks! -- * Wojciech A. Koszek && dunstan@FreeBSD.czest.pl
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050822213221.GA22155>