From owner-cvs-src@FreeBSD.ORG Fri Mar 9 04:02:38 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C72E916A40A; Fri, 9 Mar 2007 04:02:38 +0000 (UTC) (envelope-from mohans@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id B52EF13C4A8; Fri, 9 Mar 2007 04:02:38 +0000 (UTC) (envelope-from mohans@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id l2942cxq003129; Fri, 9 Mar 2007 04:02:38 GMT (envelope-from mohans@repoman.freebsd.org) Received: (from mohans@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id l2942cow003127; Fri, 9 Mar 2007 04:02:38 GMT (envelope-from mohans) Message-Id: <200703090402.l2942cow003127@repoman.freebsd.org> From: Mohan Srinivasan Date: Fri, 9 Mar 2007 04:02:38 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/amd64/amd64 trap.c src/sys/i386/i386 trap.c src/sys/ia64/ia64 trap.c src/sys/kern kern_thread.c src/sys/nfsclient nfs_socket.c nfs_subs.c nfs_vnops.c nfsnode.h src/sys/powerpc/powerpc trap.c src/sys/sparc64/sparc64 trap.c ... X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Mar 2007 04:02:38 -0000 mohans 2007-03-09 04:02:38 UTC FreeBSD src repository Modified files: sys/amd64/amd64 trap.c sys/i386/i386 trap.c sys/ia64/ia64 trap.c sys/kern kern_thread.c sys/nfsclient nfs_socket.c nfs_subs.c nfs_vnops.c nfsnode.h sys/powerpc/powerpc trap.c sys/sparc64/sparc64 trap.c sys/sys proc.h Log: Over NFS, an open() call could result in multiple over-the-wire GETATTRs being generated - one from lookup()/namei() and the other from nfs_open() (for cto consistency). This change eliminates the GETATTR in nfs_open() if an otw GETATTR was done from the namei() path. Instead of extending the vop interface, we timestamp each attr load, and use this to detect whether a GETATTR was done from namei() for this syscall. Introduces a thread-local variable that counts the syscalls made by the thread and uses as the attrload timestamp. Thanks to jhb@ and peter@ for a discussion on thread state that could be used as the timestamp with minimal overhead. Revision Changes Path 1.314 +2 -0 src/sys/amd64/amd64/trap.c 1.299 +2 -0 src/sys/i386/i386/trap.c 1.126 +2 -0 src/sys/ia64/ia64/trap.c 1.241 +1 -0 src/sys/kern/kern_thread.c 1.151 +1 -1 src/sys/nfsclient/nfs_socket.c 1.145 +9 -0 src/sys/nfsclient/nfs_subs.c 1.274 +10 -1 src/sys/nfsclient/nfs_vnops.c 1.60 +11 -0 src/sys/nfsclient/nfsnode.h 1.64 +2 -0 src/sys/powerpc/powerpc/trap.c 1.87 +3 -0 src/sys/sparc64/sparc64/trap.c 1.473 +1 -0 src/sys/sys/proc.h