From owner-freebsd-bugs@FreeBSD.ORG Tue May 31 12:00:18 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6D48516A470 for ; Tue, 31 May 2005 12:00:18 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7C2E143D58 for ; Tue, 31 May 2005 12:00:17 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j4VC0HB5011603 for ; Tue, 31 May 2005 12:00:17 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j4VC0HBG011599; Tue, 31 May 2005 12:00:17 GMT (envelope-from gnats) Resent-Date: Tue, 31 May 2005 12:00:17 GMT Resent-Message-Id: <200505311200.j4VC0HBG011599@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Diane Bruce Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AA2AC16A41C for ; Tue, 31 May 2005 11:57:03 +0000 (GMT) (envelope-from db@db.net) Received: from heceta.db.net (heceta.db.net [142.46.199.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 692A943D1F for ; Tue, 31 May 2005 11:57:03 +0000 (GMT) (envelope-from db@db.net) Received: from heceta.db.net ([142.46.199.182] helo=localhost ident=mailnull) by heceta.db.net with esmtp (Exim 4.24; FreeBSD 4.8) id 1Dd5Nl-000IES-KV for freebsd-gnats-submit@freebsd.org; Tue, 31 May 2005 07:58:05 -0400 Received: from localhost.dbn ([127.0.0.1] helo=night.db.net) by night.db.net with esmtp (Exim 4.50 (FreeBSD)) id 1Dd5NW-0008Uh-R7 for FreeBSD-gnats-submit@freebsd.org; Tue, 31 May 2005 07:57:50 -0400 Received: (from db@localhost) by night.db.net (8.13.3/8.13.1/Submit) id j4VBvmhq032654; Tue, 31 May 2005 07:57:48 -0400 (EDT) (envelope-from db) Message-Id: <200505311157.j4VBvmhq032654@night.db.net> Date: Tue, 31 May 2005 07:57:48 -0400 (EDT) From: Diane Bruce To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: bin/81709: lam accepts -P but not -p X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Diane Bruce List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 May 2005 12:00:18 -0000 >Number: 81709 >Category: bin >Synopsis: lam accepts -P but not -p >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue May 31 12:00:16 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Diane Bruce >Release: FreeBSD 5.4-RELEASE-p1 i386 >Organization: Very unorganized. >Environment: System: FreeBSD night.db.net 5.4-RELEASE-p1 FreeBSD 5.4-RELEASE-p1 #7: Thu May 19 07:07:49 EDT 2005 root@:/usr/src/sys/i386/compile/NIGHT i386 >Description: lam honours the -P flag but not the -p flag, which should do exactly the same thing. >How-To-Repeat: echo A > f1 echo B > f2 echo C >> f2 lam -P 1.1 f1 f2 AB C lam -p 1.1 f1 f2 AB C >Fix: This patch will fix it, but it really should be rewritten. PATCH tested --- lam.c.orig Tue May 31 07:03:26 2005 +++ lam.c Tue May 31 06:57:40 2005 @@ -120,7 +120,8 @@ else if ((ip->fp = fopen(p, "r")) == NULL) { err(1, "%s", p); } - ip->pad = P; + if(!ip->pad) + ip->pad = P; if (!ip->sepstring) ip->sepstring = (S ? (ip-1)->sepstring : ""); if (!ip->format) >Release-Note: >Audit-Trail: >Unformatted: