Date: Sun, 15 Feb 2009 17:22:27 -0800 From: Garrett Cooper <yanefbsd@gmail.com> To: Mario Pavlov <freebsd@abv.bg> Cc: dev@lists.pcbsd.org, kris@pcbsd.com, freebsd-current@freebsd.org, freebsd-amd64@freebsd.org Subject: Re: [Fw: Re: [PC-BSD Dev] vmap()-like kernel interface ] Message-ID: <7d6fde3d0902151722x24aeed88na79ed5093f5d2569@mail.gmail.com> In-Reply-To: <442505824.71673.1234559053919.JavaMail.apache@mail53.abv.bg> References: <442505824.71673.1234559053919.JavaMail.apache@mail53.abv.bg>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Feb 13, 2009 at 1:04 PM, Mario Pavlov <freebsd@abv.bg> wrote:
> Hi,
> please find the attached e-mail
>
> regards
> mgp
>
> P.S. thanks, PC-BSD team
I'm not a kernel dev, but I noted that pmap_unmapcontig doesn't
take into consideration when va is NULL; I know it's bad driver
programming if uncontig is implicitly called with NULL, but there
should be some error handling or something here (a NULL deref will
occur in pmap_qremove, which will cause a panic).
Thanks,
-Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7d6fde3d0902151722x24aeed88na79ed5093f5d2569>