Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 22 Apr 2002 16:03:36 -0700
From:      "David O'Brien" <obrien@FreeBSD.ORG>
To:        Mike Barcroft <mike@FreeBSD.ORG>
Cc:        cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject:   Re: cvs commit: src/usr.bin/ldd ldd.c sods.c
Message-ID:  <20020422160336.A90450@dragon.nuxi.com>
In-Reply-To: <20020422180652.A72727@espresso.q9media.com>; from mike@FreeBSD.ORG on Mon, Apr 22, 2002 at 06:06:52PM -0400
References:  <200204202009.g3KK9Uh55665@freefall.freebsd.org> <20020422111856.B49799@dragon.nuxi.com> <20020422180652.A72727@espresso.q9media.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 22, 2002 at 06:06:52PM -0400, Mike Barcroft wrote:
> > >   Modified files:
> > >     usr.bin/ldd          ldd.c sods.c 
> > >   Log:
> > >   Include <arpa/inet.h> for prototype of ntohl() used in the N_BADMAG()
> > >   macro.
> > 
> > This seems very silly -- 'ldd' has zero to do with networking.  Perhaps
> > ntohl really needs to be moved to another header, which apra/inet.h
> > includes.
> 
> Then why is it using Network to host conversion macros?  The Standard
> defines these macros in <arpa/inet.h> and <netinet/in.h>.  We used to

It is used in /usr/include/sys/imgact_aout.h:#define  N_BADMAG(ex) \
which is because we had no other endian conversion bits at the time.
This could be changed to what ever bits you and tmm crafted.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020422160336.A90450>