From owner-svn-src-all@FreeBSD.ORG Sun Jan 11 22:02:28 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CEBF513A; Sun, 11 Jan 2015 22:02:28 +0000 (UTC) Received: from mail-wi0-x22e.google.com (mail-wi0-x22e.google.com [IPv6:2a00:1450:400c:c05::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6EB9E85E; Sun, 11 Jan 2015 22:02:28 +0000 (UTC) Received: by mail-wi0-f174.google.com with SMTP id h11so11210463wiw.1; Sun, 11 Jan 2015 14:02:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=gnF/H7JYZ6zsSXnK+SmzXUxFToFU+ioi0QwRQR315Qc=; b=t5ZQqL/3Yjb2NOgID8c7sN8kOyj56ofUfDD06oc7Ohv+B/tIJspU1NmzCJ9542pRMO 4FkwUbWZFDH6sOt5QWnr9O/N6c39ILWQG3bICyip5FliQfEYbNLTVHCLsbahLGmx6mvT FVMZ+7tsE77OWnuD3YoBs/W3hNMZUVuPlY8zQJPQe5XarkQK/THKVCrFZaf3tW7eMgTj dJdFeJyH2BxVehhjQxEdMBv81p9v/R51VNf6po49f0/KNqJ6a2aKvaZmDjRoShPq54JC Iu5NB+LRqdpD/udhDPBfKrQ/5d65xHbDo94OErqRKkctOtdfpRxjL52zw635+n6TxC/Z TcbA== X-Received: by 10.180.93.1 with SMTP id cq1mr24292320wib.2.1421013747012; Sun, 11 Jan 2015 14:02:27 -0800 (PST) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id r3sm7704101wic.10.2015.01.11.14.02.25 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Jan 2015 14:02:26 -0800 (PST) Sender: Baptiste Daroussin Date: Sun, 11 Jan 2015 23:02:24 +0100 From: Baptiste Daroussin To: Konstantin Belousov Subject: Re: svn commit: r276962 - head/lib/liblzma Message-ID: <20150111220223.GB17273@ivaldir.etoilebsd.net> References: <201501110925.t0B9P2Sg005368@svn.freebsd.org> <20150111212744.GE42409@kib.kiev.ua> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="E39vaYmALEf/7YXx" Content-Disposition: inline In-Reply-To: <20150111212744.GE42409@kib.kiev.ua> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Jan 2015 22:02:29 -0000 --E39vaYmALEf/7YXx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 11, 2015 at 11:27:44PM +0200, Konstantin Belousov wrote: > On Sun, Jan 11, 2015 at 09:25:02AM +0000, Baptiste Daroussin wrote: > > Author: bapt > > Date: Sun Jan 11 09:25:01 2015 > > New Revision: 276962 > > URL: https://svnweb.freebsd.org/changeset/base/276962 > >=20 > > Log: > > Do not regenerate and install liblzma.pc when only build libraries > > aka do not regenerate while generating 32bits libs > > =20 > > Reported by: antoine > >=20 > > Modified: > > head/lib/liblzma/Makefile > >=20 > > Modified: head/lib/liblzma/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/lib/liblzma/Makefile Sun Jan 11 08:40:01 2015 (r276961) > > +++ head/lib/liblzma/Makefile Sun Jan 11 09:25:01 2015 (r276962) > > @@ -148,12 +148,13 @@ CFLAGS+=3D -DSYMBOL_VERSIONING > > =20 > > CLEANFILES+=3D liblzma.pc > > =20 > > +.if !defined(LIBRARIES_ONLY) > > all: liblzma.pc > I think that much better define to differentiate on would be COMPAT_32BIT. >=20 > That said, head and stable/10 should be almost clean now for allowing > ports and third-party software to work with cc -m32. I think > that this commit makes it in other direction. >=20 > Could the .pc files for base system provided by some port ? >=20 I think the best would probably be to create a bsd.pc.mk which act a bit li= ke bsd.incs.mk Concerning pushing all of those .pc files into a port, I'm not against it, actually it would be even simpler for ports as it will affect all the ports= at once. But on the other hands that would mean on port with different content based on OSVERSIONS, I think keeping it in base would be more accurate. Best regards, Bapt --E39vaYmALEf/7YXx Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlSy8uwACgkQ8kTtMUmk6ExuTgCfTcaURcUPyfcMSiqi8fdQYKPD CUgAniUtyx7rfNo2nZONj2d08Ym1dQOp =WDgi -----END PGP SIGNATURE----- --E39vaYmALEf/7YXx--