Date: Thu, 20 May 2021 17:20:09 -0600 From: Warner Losh <imp@bsdimp.com> To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Cc: git@freebsd.org Subject: Re: src tools/tools/git/hooks/prepare-commit-msg ? Message-ID: <CANCZdfpJW6WnWCJXxBzVi=AkDbZ4teJippahkXkvB263uXrnGA@mail.gmail.com> In-Reply-To: <alpine.BSF.2.00.2105191230150.4751@ai.fobar.qr> References: <alpine.BSF.2.00.2105191230150.4751@ai.fobar.qr>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000dbf6e405c2cb2f19 Content-Type: text/plain; charset="UTF-8" Hi Bjoern, Sorry to take a little to get back to you... I was on travel and got behind... On Wed, May 19, 2021 at 6:38 AM Bjoern A. Zeeb < bzeeb-lists@lists.zabbadoz.net> wrote: > Hi, > > before committer's guide (CG) git docs on Warner's github the tags were > documented as "Foo-bar:" ineast of the old "Foo bar": ; see: > > https://github.com/bsdimp/freebsd-git-docs/blob/096afef4a8b9d8964f9edaf3d15e484b1ead83d3/meta.md > (with the later fix for Phabricator). > > It seems tools/tools/git/hooks/prepare-commit-msg in the source tree > was never updated to that? > > I can find a reference to the hook in the ports (not in the src) section > "5.2.6.1. Commit message formats" of the CG and the referenced file > for ports also was never changed it seems. > > Did we drop the idea of adding the "-" into the "tags"? > > > I am asking because I kept using them from back then and noticed that > I am missing a lot of MFC reminders (though I thought that was > adjusted to cope with the '-' as well). So I am trying to sort out > the official format before opening the next can. > I think that you should omit them, and if we still document them like that we should change it. The git group tried to promulgate the change, but it has had poor uptake. Either that, or we need to make the mfc stuff work again... Though given the numbers of people that have used the '-' versions appears to be low, I think we'll need to relaunch in the future instead. Warner > /bz > > -- > Bjoern A. Zeeb r15:7 > > --000000000000dbf6e405c2cb2f19 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr">Hi Bjoern,<div><br></div><div>Sorry to ta= ke a little to get back to you... I was on travel and got behind...</div></= div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On= Wed, May 19, 2021 at 6:38 AM Bjoern A. Zeeb <<a href=3D"mailto:bzeeb-li= sts@lists.zabbadoz.net">bzeeb-lists@lists.zabbadoz.net</a>> wrote:<br></= div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bor= der-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br> <br> before committer's guide (CG) git docs on Warner's github the tags = were<br> documented as "Foo-bar:" ineast of the old "Foo bar":= =C2=A0 ; see:<br> <a href=3D"https://github.com/bsdimp/freebsd-git-docs/blob/096afef4a8b9d896= 4f9edaf3d15e484b1ead83d3/meta.md" rel=3D"noreferrer" target=3D"_blank">http= s://github.com/bsdimp/freebsd-git-docs/blob/096afef4a8b9d8964f9edaf3d15e484= b1ead83d3/meta.md</a><br> (with the later fix for Phabricator).<br> <br> It seems tools/tools/git/hooks/prepare-commit-msg in the source tree<br> was never updated to that?<br> <br> I can find a reference to the hook in the ports (not in the src) section<br= > "5.2.6.1. Commit message formats" of the CG and the referenced fi= le<br> for ports also was never changed it seems.<br> <br> Did we drop the idea of adding the "-" into the "tags"?= <br> <br> <br> I am asking because I kept using them from back then and noticed that<br> I am missing a lot of MFC reminders (though I thought that was<br> adjusted to cope with the '-' as well).=C2=A0 So I am trying to sor= t out<br> the official format before opening the next can.<br></blockquote><div><br><= /div><div>I think that you should omit them, and if we still document them = like that</div><div>we should change it. The git group tried to promulgate = the change, but</div><div>it has had poor uptake.</div><div><br></div><div>= Either that, or we need to make the mfc stuff work again... Though given th= e</div><div>numbers of people that have used the '-' versions appea= rs to be low, I think</div><div>we'll need to relaunch in the future in= stead.</div><div><br></div><div>Warner</div><div>=C2=A0</div><blockquote cl= ass=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid= rgb(204,204,204);padding-left:1ex"> /bz<br> <br> -- <br> Bjoern A. Zeeb=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0r15:7<br> <br> </blockquote></div></div> --000000000000dbf6e405c2cb2f19--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpJW6WnWCJXxBzVi=AkDbZ4teJippahkXkvB263uXrnGA>