Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 28 Nov 2017 19:19:52 +0000
From:      bugzilla-noreply@freebsd.org
To:        xfce@FreeBSD.org
Subject:   [Bug 202192] [PATCH] x11-fm/thunar 1.6.11 change file permissions on sshfs mounted files/dirs
Message-ID:  <bug-202192-28711-LQ7cwO72e3@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-202192-28711@https.bugs.freebsd.org/bugzilla/>
References:  <bug-202192-28711@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D202192

--- Comment #7 from Guido Falsi <madpilot@FreeBSD.org> ---
(In reply to rozhuk.im from comment #6)
> (In reply to Guido Falsi from comment #5)
>=20
> https://bugzilla.xfce.org/show_bug.cgi?id=3D12863
> year+ - no activity in upstream, is there are life?

This is irrelevant and in fact against your interest to point this out.

If a patch is not accepted upstream maybe there are reasons for that.

Also the fact the patch is not accepted upstream, even if accepting without
question it to be good, is no reason to push it in FreeBSD. It could add
unexpected effects.

It will also make updating the port more difficult. The patched code could =
be
modified upstream and the patch need reconciliation, or changes upstream can
cause the patch to break.

>=20
> Yes, our port does not have GIO option, I do tests by add to makefile GIO
> option and uncheck it.

So the GIO case is irrelevant to our ports tree. No need to diverge to fix a
problem that cannot happen.

>=20
>=20
> I dont know what I need to do with upstream, they do not react on bug tac=
ker.
>=20

While I understand your frustration I have no connection with the upstream.

If you get your code accepted by upstream that is proof of a minimum qualit=
y of
the change and also will mean thee code will anyway get in the ports tree, =
so
there is no reason to hold the change.

If you cannot some FreeBSD committer needs to test check and make a decisio=
n,
this takes time. This is a volunteer project and no one is paid for it or
working full time on port bugs. Things may require time.

Please give me time to evaluate your code properly.

This is a "port" of the upstream code not original code. Any divergence nee=
ds a
good motivation.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-202192-28711-LQ7cwO72e3>