From owner-cvs-src@FreeBSD.ORG Mon Sep 12 20:20:05 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1BA6816A41F; Mon, 12 Sep 2005 20:20:05 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [204.156.12.53]) by mx1.FreeBSD.org (Postfix) with ESMTP id C1D4143D49; Mon, 12 Sep 2005 20:20:04 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by cyrus.watson.org (Postfix) with ESMTP id F080646B4F; Mon, 12 Sep 2005 16:20:03 -0400 (EDT) Date: Mon, 12 Sep 2005 21:20:03 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: John-Mark Gurney In-Reply-To: <20050912201136.GK793@funkthat.com> Message-ID: <20050912211820.W96771@fledge.watson.org> References: <200509111303.j8BD3bTK042313@repoman.freebsd.org> <20050912201136.GK793@funkthat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/tools/regression/fifo/fifo_open Makefile fifo_open.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2005 20:20:05 -0000 On Mon, 12 Sep 2005, John-Mark Gurney wrote: > Robert Watson wrote this message on Sun, Sep 11, 2005 at 13:03 +0000: >> rwatson 2005-09-11 13:03:36 UTC >> >> FreeBSD src repository >> >> Added files: >> tools/regression/fifo/fifo_open Makefile fifo_open.c >> Log: >> Add fifo_open, a basic regression test for opening fifos, which tests >> the blocking and non-blocking forms of open based on the POSIX spec for >> now O_NONBLOCK should be handled. > > I assume we aren't going to follow the useless POSIX spec for handling > O_NONBLOCK'ing reads wrt select and friends? If you're interested in a > basic test case, I can send you one... > > (That selecting on a fifo for read that doesn't have a writer will > return true, due to the fact that EOF is available for reading on a > O_NONBLOCK fifo.) Right now I haven't implemented tests for select/poll/kqueue that involve activity on a fifo where only one endpoint is open. I largely implemented these regression tests so I could try to avoid breaking fifos when fixing a race condition that Kris and others have been running into. Along the way, I ran into a lot of bugs that had to be fixed before I could run the tests successfully :-). I'm going to work on the race itself now and revisit further testing of half-open fifos in the future (there are some XXX's in the test code to indicate some of the uncovered cases I'm aware of). Robert N M Watson