Date: Fri, 10 Oct 2008 08:49:21 -0700 From: Marcel Moolenaar <xcllnt@mac.com> To: Rafal Jaworowski <raj@semihalf.com> Cc: freebsd-arm@freebsd.org Subject: Re: FreeBSD/arm support for Marvell chips -- please review Message-ID: <F2854257-4DC0-4812-8D04-F42DC44D8EFC@mac.com> In-Reply-To: <48EF2481.2010307@semihalf.com> References: <48DA31B3.5040906@semihalf.com> <48EF2481.2010307@semihalf.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Oct 10, 2008, at 2:46 AM, Rafal Jaworowski wrote: > Rafal Jaworowski wrote: >> All, >> With the recent series of submits in P4's arm-devel branch, I have >> completed >> import of FreeBSD/arm support for three families of Marvell >> integrated >> systems-on-chip built on ARMv5TE-compliant core. Orion support has >> been around >> for a while already, and recently added were extensions for >> Kirkwood and >> Discovery support, new drivers for integrated peripherals and other >> improvements. >> >> I'd like to merge this with SVN within the coming weeks, so would >> like to ask >> everyone to review the code and let me know about any comments or >> notes: > > I haven't received much feedback, are people still reviewing this? Just my $0.02: I personally don't like the deep nesting of directories, but other than that: it looks and works great. I have some tweaks to add later. For example: FPA support on little endian ARM (FPA has the words in big-endian, irrespective of the byte order). We have 4 places where we define the IEEE representation and where we need to account for this. FYI, -- Marcel Moolenaar xcllnt@mac.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F2854257-4DC0-4812-8D04-F42DC44D8EFC>