From owner-freebsd-arm@FreeBSD.ORG Fri Oct 10 16:49:35 2008 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 51B7B106568F for ; Fri, 10 Oct 2008 16:49:35 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from asmtpout021.mac.com (asmtpout021.mac.com [17.148.16.96]) by mx1.freebsd.org (Postfix) with ESMTP id 40B3A8FC15 for ; Fri, 10 Oct 2008 16:49:35 +0000 (UTC) (envelope-from xcllnt@mac.com) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Received: from macbook-pro.jnpr.net (natint3.juniper.net [66.129.224.36]) by asmtp021.mac.com (Sun Java(tm) System Messaging Server 6.3-7.03 (built Aug 7 2008; 32bit)) with ESMTPSA id <0K8J001C85A9ZD32@asmtp021.mac.com> for freebsd-arm@freebsd.org; Fri, 10 Oct 2008 08:49:22 -0700 (PDT) Message-id: From: Marcel Moolenaar To: Rafal Jaworowski In-reply-to: <48EF2481.2010307@semihalf.com> Date: Fri, 10 Oct 2008 08:49:21 -0700 References: <48DA31B3.5040906@semihalf.com> <48EF2481.2010307@semihalf.com> X-Mailer: Apple Mail (2.929.2) Cc: freebsd-arm@freebsd.org Subject: Re: FreeBSD/arm support for Marvell chips -- please review X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Oct 2008 16:49:35 -0000 On Oct 10, 2008, at 2:46 AM, Rafal Jaworowski wrote: > Rafal Jaworowski wrote: >> All, >> With the recent series of submits in P4's arm-devel branch, I have >> completed >> import of FreeBSD/arm support for three families of Marvell >> integrated >> systems-on-chip built on ARMv5TE-compliant core. Orion support has >> been around >> for a while already, and recently added were extensions for >> Kirkwood and >> Discovery support, new drivers for integrated peripherals and other >> improvements. >> >> I'd like to merge this with SVN within the coming weeks, so would >> like to ask >> everyone to review the code and let me know about any comments or >> notes: > > I haven't received much feedback, are people still reviewing this? Just my $0.02: I personally don't like the deep nesting of directories, but other than that: it looks and works great. I have some tweaks to add later. For example: FPA support on little endian ARM (FPA has the words in big-endian, irrespective of the byte order). We have 4 places where we define the IEEE representation and where we need to account for this. FYI, -- Marcel Moolenaar xcllnt@mac.com