Date: Sun, 24 Mar 2013 00:53:37 +0400 From: Andrey Chernov <ache@freebsd.org> To: Gabor Kovesdan <gabor@FreeBSD.org> Cc: svn-ports-head@freebsd.org, Baptiste Daroussin <bapt@FreeBSD.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r314581 - in head: converters/libiconv devel/gettext Message-ID: <514E1651.8090902@freebsd.org> In-Reply-To: <514E1379.2020301@FreeBSD.org> References: <201303181551.r2IFpdl7099804@svn.freebsd.org> <51473F55.9000106@freebsd.org> <20130318165603.GL72627@ithaqua.etoilebsd.net> <514E1379.2020301@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 24.03.2013 0:41, Gabor Kovesdan wrote: > Em 18-03-2013 17:56, Baptiste Daroussin escreveu: >>> There is also similar problem with textproc/gnugrep (if installed). >>> >In worst case it depends on both libintl and libiconv and only on >>> >libiconv (for the reason unknown, probably unneeded, dependency is not >>> >present in its makefile) if compiled without NLS. >>> > >> Crap thanks for notice, I'm preparing a config.site so that we can >> specify all >> of this cleanly but I haven't finished and it will need an exp-run. > So is there something I can do in gnugrep to fix this problem or will it > be handled globally somehow? I don't examine sources yet, but I doubt that libiconv without NLS is really needed, but currently linked with gnugrep, if NLS is disabled: /usr/local/bin/grep: libiconv.so.3 => /usr/local/lib/libiconv.so.3 (0x28093000) libc.so.7 => /lib/libc.so.7 (0x2818a000) Moreover, I don't see libiconv dependency in the gnugrep port Makefile. If libiconv without NLS is unneeded, gnugrep configure should be patched to not pick it up. In that case simple knob WITHOUT_NLS gives no external dependencies for gnugrep (libc is not counted). If libiconv is needed, we don't have a choice to reduce dependecy, so port's system should use /usr/bin/grep by its full path. In that case libiconv dependency should be added to the gnugrep port Makefile.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?514E1651.8090902>