Date: Wed, 5 Dec 2007 06:48:43 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: d@delphij.net Cc: Frank Behrens <frank@pinky.sax.de>, cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/i386/i386 trap.c src/sys/amd64/amd64 trap.c Message-ID: <20071205044843.GA83121@deviant.kiev.zoral.com.ua> In-Reply-To: <4756014C.4070501@delphij.net> References: <200712041233.lB4CX3E0041915@repoman.freebsd.org> <200712041436.lB4EafSA039456@post.frank-behrens.de> <20071204150053.GY83121@deviant.kiev.zoral.com.ua> <4756007F.7090706@delphij.net> <4756014C.4070501@delphij.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--IdQYvU5iz1n5pUC3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 04, 2007 at 05:39:24PM -0800, Xin LI wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 >=20 > By the way, I think the comment "always SIGSEGV mode" should be "POSIX > mode", as it is defined POSIX behavior, but that is not a big deal, thoug= h. It is not trully POSIX mode, as was pointed out (to me) before. POSIXyzing it would be a future project. For now, it would delay an already late release. About your patch: I would answer the same as to the Frank: I do not like #ifdefs; it misses the (non-existing) option for compatibility with early 7-CURRENT. Also, it would provide quite non-obvious change in the behaviour. Usually, COMPAT_XXX turns off the features, so you simply cannot execute something without proper COMPAT_XXX. There, you would get wrong run-time behaviour. >=20 > Cheers, > - -- > Xin LI <delphij@delphij.net> http://www.delphij.net/ > FreeBSD - The Power to Serve! > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2.0.4 (FreeBSD) >=20 > iD8DBQFHVgFMhcUczkLqiksRAg0HAJ4qBG5GrBLgp4Qi96DhJU7t49KYIwCdF/W4 > CAelBTWPXSrE4jrq9lYpb74=3D > =3DkZj/ > -----END PGP SIGNATURE----- --IdQYvU5iz1n5pUC3 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQFHVi2qC3+MBN1Mb4gRAjBuAJ94D3fVNW4FTQ8vlDAO1ejWQd6Q2gCg8Ljk oNn548ws3hyh65391uGD0mg= =m8Tw -----END PGP SIGNATURE----- --IdQYvU5iz1n5pUC3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071205044843.GA83121>