From owner-freebsd-bugs Tue May 29 2:16: 3 2001 Delivered-To: freebsd-bugs@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by hub.freebsd.org (Postfix) with ESMTP id 477D937B424 for ; Tue, 29 May 2001 02:16:01 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter (localhost [127.0.0.1]) by critter.freebsd.dk (8.11.3/8.11.3) with ESMTP id f4T9Flf24850; Tue, 29 May 2001 11:15:48 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Dima Dorfman Cc: freebsd-bugs@FreeBSD.ORG Subject: Re: kern/26787: sysctl change request In-Reply-To: Your message of "Mon, 28 May 2001 18:10:03 PDT." <200105290110.f4T1A3u68170@freefall.freebsd.org> Date: Tue, 29 May 2001 11:15:47 +0200 Message-ID: <24848.991127747@critter> From: Poul-Henning Kamp Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org In message <200105290110.f4T1A3u68170@freefall.freebsd.org>, Dima Dorfman writes: > Either you misunderstood, or I'm missing something really, really big. > I meant that each *handler* should decide how to log it, not each > sysctl instance. Ok, I misunderstood you there. > I've attached a proof-of-concept patch to demonstrate what I mean; Looks good. > At this point, it only logs the last component > of the sysctl (e.g., if the sysctl is "kern.hostname" it will only log > "hostname") because I couldn't find a routine which gave the full > name, and writing one wasn't necessary to demonstrate the concept. Right, we don't have such a routine at this point. > Do you still think this would add too much bloat for too little gain? If it's something on this size I am all for it. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message