From owner-svn-src-all@freebsd.org Tue Jun 25 01:51:32 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9166515B440A for ; Tue, 25 Jun 2019 01:51:32 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 333646ADC9 for ; Tue, 25 Jun 2019 01:51:32 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x732.google.com with SMTP id g18so11380126qkl.3 for ; Mon, 24 Jun 2019 18:51:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OgSPO8SK7DQ2XMKh6EoaprmD8nOC94xfFVIxQIeCIIg=; b=HfxUH3VZy4sBQTfspmnYrgv458fASKMfl+DSP6gfUQz6KiEvuYN1iUZ+Zafde8hGux sDw5wizWScHWBYlygGxXNTauEqLaJJY7oC/obHxsH1OUoaqhiB/9fhlhu5q+aV/DLY6G 3j1SrLUAmTE2jedpeqXsUuxEGBeGuCZ6NqfIP+YY7wbyXwbvDEAcsQIdKFD5GDNh8EPt sDvStFuWqlo2nRnhjLriKpcQsJa1/D4uLdE1TmkP3MhTFvzubWWEnCvobw+gb/O0C5Fp qXlGb3ossOK+R/N9JD5BGWKbxo+Fk4QtdUmz9WALOsgL+REAU6wJY9jAD4YbcXtGWH/B icyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OgSPO8SK7DQ2XMKh6EoaprmD8nOC94xfFVIxQIeCIIg=; b=p045GgNiF9lAQ2iSI0TM3PIEBsaf4usrTDkSUWniQbYwvbLBo8pt/HQE6oIyV9Ur3Q cGByS1zxp73+no/x1NBI5YkGTxrirEsIeb5bpxuGjkTwOFQSdbL/ZnNWAZ8RjZbbCMwL caxewI1pu6slkhD93te9GNbbiS7ycJjRzOTPx82dyR7bf6SVjEdr7lfWDmANorv3JEd5 scCJjSDpG5+kowPjfh3On4d8mvLxtDVCb6DJ7LVK1GAiBO4SQ60udpFLeNhxBCSPmck4 JfIE4uhSoC+pz3WmPGGhpD0wwYTqRg2rAmxZPFqHtzn46p41SAGYx7MjkwBgf6icmeaJ TEPQ== X-Gm-Message-State: APjAAAXui8Jdq76jlmawC4QNYrOdl4LtR3336PVFhRboPPMpJ4PL0OSH F5bFe9P38kzLAV491TBlrkbUIypJSC92O1suBxqpIg== X-Google-Smtp-Source: APXvYqwey3xGVcdttZM26xmned+Lr4GjyBVRKHVHa8HSWdNiKEX3zq2FyKN510RhFPR3M5UDete81oaBLCJ3fgfOT5Y= X-Received: by 2002:a37:83c4:: with SMTP id f187mr19331830qkd.380.1561427491267; Mon, 24 Jun 2019 18:51:31 -0700 (PDT) MIME-Version: 1.0 References: <9046989b-f45a-12a9-954f-799ade5b08a2@freebsd.org> <201906250111.x5P1Bc9I046753@gndrsh.dnsmgr.net> In-Reply-To: <201906250111.x5P1Bc9I046753@gndrsh.dnsmgr.net> From: Warner Losh Date: Mon, 24 Jun 2019 19:51:19 -0600 Message-ID: Subject: Re: svn commit: r349349 - in head/stand: efi/include efi/include/Protocol efi/libefi efi/loader libsa To: "Rodney W. Grimes" Cc: Rebecca Cran , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 333646ADC9 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.99)[-0.992,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jun 2019 01:51:32 -0000 Hey Rod, On Mon, Jun 24, 2019 at 7:11 PM Rodney W. Grimes wrote: > -- Start of PGP signed section. > [ Charset UTF-8 unsupported, converting... ] > > On 2019-06-24 18:45, Rodney W. Grimes wrote: > > > > > It sys accompanies, that means not a pointer to.... > > > Hum oh my, what has happend to the disclaimer? > > > > Huh. It turns out the _latest_ version of that file just contains: > > > > /** @file > > This file defines the EFI HTTP Protocol interface. It is split into > > the following two main sections: > > HTTP Service Binding Protocol (HTTPSB) > > HTTP Protocol (HTTP) > > > > Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.
> > (C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP
> > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > @par Revision Reference: > > This Protocol is introduced in UEFI Specification 2.5 > > > > **/ > > > > > > I think I should update the copy in the tree with this version, which > > makes more sense. Do you agree? > Rebecca: I think it frankly doesn't matter. There's no need to go fetch a stone just to keep Rod happy. The version you committed is fine: it is a verbatim copy of the vendor source at some point in the past. I looked at and approved that license. This newer one, I'm less sure about, so please hold off on that. > If that is how the vendor is distributing it now, yes, that would > be safer as the above removes the conflict between what the file says > and what was done. > > Please note that -Patent has not been addressed by core@ to my > knowledge, and that may or may not be an issue. I shringe when > I see these clauses being blanket added to software though. > > Again with the scolding? Rebecca doesn't deserve this level of nit-picking. It is demotivating. She did a great job getting this code into the tree and you wag your finger at her for committing code verbatim from the vendor? It's totally not cool. Please stop this sort of nonsense. The rest of the project stopped this level of nit-picking back in the 90's when we all agreed it was counter productive. Warner