From owner-freebsd-hackers@freebsd.org Mon Mar 25 00:02:56 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2983C15497AD; Mon, 25 Mar 2019 00:02:56 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 67D1F6E439; Mon, 25 Mar 2019 00:02:55 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id x2P02fTi035581 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 25 Mar 2019 02:02:44 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua x2P02fTi035581 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id x2P02fZT035580; Mon, 25 Mar 2019 02:02:41 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 25 Mar 2019 02:02:41 +0200 From: Konstantin Belousov To: Rebecca Cran Cc: FreeBSD Hackers , arch@freebsd.org Subject: Re: Adding a new efi-update-loader script: need help understanding Makefile.inc1 for "make installworld" Message-ID: <20190325000241.GS1923@kib.kiev.ua> References: <642fed43-0535-9ae3-6f01-a943650cd511@bluestop.org> <20190324090103.GO1923@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tom.home X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Mar 2019 00:02:56 -0000 On Sun, Mar 24, 2019 at 05:47:23PM -0600, Rebecca Cran wrote: > On 3/24/19 3:01 AM, Konstantin Belousov wrote: > > > > > Can we take use of the opportunity and finally stop installing loader > > at installworld target at all, please ? > > > > Add e.g. installloader target which would do whatever needed to loader. > > > Others have suggested adding a new step as well. I'm not sure we need it > as a make target, but perhaps a generic script such as "update-loader" > that will call "efi-update-loader" if on a UEFI system, or "boot0cfg" > etc. on an MBR system (i.e. it knows how to install boot/loader code for > all systems we support)? Also, about the naming: would you prefer > 'install' or 'update' in the script name? I do not see the need in the script which would call another commands. Having efi_update_loader alone would be fine, but I doubt that this script can do much except in situations where a lot of pre-assumptions are true. I believe that despite all the efforts put into efibootmgr and installer, it is hard/impossible to make the script not dangerous, except if the whole configuration was created by our installer. > > > When you say "stop installing loader", do you mean stop installing > /boot/loader* entirely, or leave installworld installing those, but have > updating the ESP as the extra step? I mean 'do not touch my ESP' on installworld.