From owner-cvs-all@FreeBSD.ORG Mon Jun 18 13:38:29 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id B969016A421; Mon, 18 Jun 2007 13:38:29 +0000 (UTC) (envelope-from tom@tomjudge.com) Received: from s200aog12.obsmtp.com (s200aog12.obsmtp.com [207.126.144.126]) by mx1.freebsd.org (Postfix) with SMTP id 87D9B13C46E; Mon, 18 Jun 2007 13:38:26 +0000 (UTC) (envelope-from tom@tomjudge.com) Received: from source ([217.206.187.80]) by eu1sys200aob012.postini.com ([207.126.147.11]) with SMTP; Mon, 18 Jun 2007 13:38:26 UTC Received: from [10.0.0.89] (bill.mintel.co.uk [10.0.0.89]) by rodney.mintel.co.uk (Postfix) with ESMTP id EF62418141C; Mon, 18 Jun 2007 14:05:39 +0100 (BST) Message-ID: <467682C3.4020701@tomjudge.com> Date: Mon, 18 Jun 2007 14:04:03 +0100 From: Tom Judge User-Agent: Thunderbird 1.5.0.12 (X11/20070604) MIME-Version: 1.0 To: Andre Oppermann References: <200706110155.l5B1t9d9043150@repoman.freebsd.org> <466CFBE2.1090907@freebsd.org> <20070611074456.GE39661@cdnetworks.co.kr> <466CFEC1.6080100@freebsd.org> In-Reply-To: <466CFEC1.6080100@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: pyunyh@gmail.com, src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, rwatson@freebsd.org, Pyun YongHyeon Subject: Re: cvs commit: src/sys/dev/msk if_msk.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2007 13:38:29 -0000 Andre Oppermann wrote: > Pyun YongHyeon wrote: >> On Mon, Jun 11, 2007 at 09:38:10AM +0200, Andre Oppermann wrote: >> > Pyun YongHyeon wrote: >> > >yongari 2007-06-11 01:55:09 UTC >> > > >> > > FreeBSD src repository >> > > >> > > Modified files: >> > > sys/dev/msk if_msk.c > > Log: >> > > Disable automatic IP ID increment. Due to a hardware bug the >> automatic >> > > IP ID increment in TSO case generated corrupted IP packets. >> > > This change brings back TSO capability. >> > > > > Revision Changes Path >> > > 1.16 +0 -15 src/sys/dev/msk/if_msk.c >> > > Please add check for the DF (Don't fragment) bit in the IP header. >> > Otherwise we may run into trouble when fragmentation happens along >> > the path. We almost always set DF on TCP connections. If it is not >> > set please return EMSGSIZE which will cause TSO to be turned off. >> > >> Is there any way to return EMSGSIZE to upper layer? >> if_start has return type void. >> Or just dropping the packet if DF bit was not set is enough? > > Dropping the packet is not enough. I forgot the IF queue which > separates the downpath from the encap function... Don't know > how you can pass up the error. Robert wanted to change the drivers > queuing model, that would make it possible. CC'ed. > Sorry for jumping in here, but could you not pass the message back up by dropping the packet and sending a ICMP error back up the stack with the Error code set for "Fragmentation needed and DF set" and set the MTU hint to the current interface MTU? Or is this a stupid idea? Tom