From owner-cvs-all@FreeBSD.ORG Wed Aug 24 22:14:19 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 13DBD16A41F; Wed, 24 Aug 2005 22:14:19 +0000 (GMT) (envelope-from gad@FreeBSD.org) Received: from smtp2.server.rpi.edu (smtp2.server.rpi.edu [128.113.2.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 37A5D43D46; Wed, 24 Aug 2005 22:14:17 +0000 (GMT) (envelope-from gad@FreeBSD.org) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp2.server.rpi.edu (8.13.0/8.13.0) with ESMTP id j7OMEGKW029764; Wed, 24 Aug 2005 18:14:17 -0400 Mime-Version: 1.0 Message-Id: In-Reply-To: <20050824205627.GD755@garage.freebsd.pl> References: <200508241938.j7OJcSNW066686@repoman.freebsd.org> <200508241602.59424.jhb@FreeBSD.org> <20050824205627.GD755@garage.freebsd.pl> Date: Wed, 24 Aug 2005 18:14:15 -0400 To: Pawel Jakub Dawidek , John Baldwin From: Garance A Drosehn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-CanItPRO-Stream: default X-RPI-SA-Score: undef - spam-scanning disabled X-Scanned-By: CanIt (www . canit . ca) on 128.113.2.2 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/pkill pkill.1 pkill.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Aug 2005 22:14:19 -0000 At 10:56 PM +0200 8/24/05, Pawel Jakub Dawidek wrote: >On Wed, Aug 24, 2005, John Baldwin wrote: >+> On Wednesday 24 August 2005, Pawel Jakub Dawidek wrote: >+> > Log: >+> > Modify '-F' option to work nicely with pidfile(3) - a pidfile >+> > given as an argument has to be locked. >+> > >+> >+> I guess the only thing that makes me uncomfortable about this >+> change is that it means pkill won't work with 3rd party program's >+> pid files since they are probably not using pidfile(3). Maybe >+> have some way of turning off the flock requirement? I must admit that I did not quite understand what you had meant in your earlier messages about changes to `pkill' to match your new pid-handling library routines. I agree with John, this change doesn't seem quite right to me. >Some daemons, even if they don't use pidfile(3), they do use flock(2) >to lock the pidfile (eg. cron(8)). I added this option to pkill(1) >in the past, but I wasn't very happy with it until today... > >On the other hand, I added it to avoid: kill `cat /var/run/daemon.pid`... > >Hmm, what do you think about reverting '-F' behaviour and make it >use flock(2) only when '-L' is also given? Something like that would be good, I think. The previous change was useful as it was, even though I agree it is even more useful for pkill to pay attention to file-locking when it can. I'd slightly prefer something other than adding another option, but I can't think of anything which is particularly better. The only other suggestion might be to have "daemon.lpid" filenames instead of "daemon.pid", but that also seems icky to me. -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@FreeBSD.org Rensselaer Polytechnic Institute; Troy, NY; USA