From owner-freebsd-bugs@FreeBSD.ORG Tue Jul 12 16:40:11 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D137E16A41C for ; Tue, 12 Jul 2005 16:40:11 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5D7C243D49 for ; Tue, 12 Jul 2005 16:40:11 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j6CGeBAp055986 for ; Tue, 12 Jul 2005 16:40:11 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j6CGeBu6055985; Tue, 12 Jul 2005 16:40:11 GMT (envelope-from gnats) Resent-Date: Tue, 12 Jul 2005 16:40:11 GMT Resent-Message-Id: <200507121640.j6CGeBu6055985@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dan Lukes Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C216916A41C for ; Tue, 12 Jul 2005 16:34:13 +0000 (GMT) (envelope-from dan@kulesh.obluda.cz) Received: from kulesh.obluda.cz (kulesh.obluda.cz [193.179.22.243]) by mx1.FreeBSD.org (Postfix) with ESMTP id A7A8D43D46 for ; Tue, 12 Jul 2005 16:34:12 +0000 (GMT) (envelope-from dan@kulesh.obluda.cz) Received: from kulesh.obluda.cz (localhost.eunet.cz [127.0.0.1]) by kulesh.obluda.cz (8.13.3/8.13.3) with ESMTP id j6CGYAIf015767 for ; Tue, 12 Jul 2005 18:34:10 +0200 (CEST) (envelope-from dan@kulesh.obluda.cz) Received: (from root@localhost) by kulesh.obluda.cz (8.13.3/8.13.1/Submit) id j6CGY9BP015766; Tue, 12 Jul 2005 18:34:09 +0200 (CEST) (envelope-from dan) Message-Id: <200507121634.j6CGY9BP015766@kulesh.obluda.cz> Date: Tue, 12 Jul 2005 18:34:09 +0200 (CEST) From: Dan Lukes To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: bin/83338: [ PATCH ] libc's getent() don't check for malloc failure X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Dan Lukes List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2005 16:40:11 -0000 >Number: 83338 >Category: bin >Synopsis: [ PATCH ] libc's getent() don't check for malloc failure >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Jul 12 16:40:10 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Dan Lukes >Release: FreeBSD 5.4-STABLE i386 >Organization: Obludarium >Environment: System: FreeBSD 5.4-STABLE #8: Sat Jul 9 16:31:08 CEST 2005 i386 src/lib/libc/gen/getcap.c,v 1.19 2003/01/02 10:19:43 thomas >Description: getent() called from cgetent() don't check for malloc failure >How-To-Repeat: >Fix: --- patch begins here --- --- lib/libc/gen/getcap.c.ORIG Thu Jan 2 20:26:24 2003 +++ lib/libc/gen/getcap.c Tue Jul 12 18:27:20 2005 @@ -255,9 +255,11 @@ return (retval); } /* save the data; close frees it */ - clen = strlen(record); - cbuf = malloc(clen + 1); - memcpy(cbuf, record, clen + 1); + if ((clen = strdup(record)) == NULL) { + capdbp->close(capdbp); + errno = ENOMEM; + return (-2); + } if (capdbp->close(capdbp) < 0) { free(cbuf); return (-2); --- patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: