From owner-freebsd-ports@FreeBSD.ORG Fri Jan 27 17:45:14 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 591E21065697 for ; Fri, 27 Jan 2012 17:45:14 +0000 (UTC) (envelope-from m.seaman@infracaninophile.co.uk) Received: from smtp.infracaninophile.co.uk (smtp6.infracaninophile.co.uk [IPv6:2001:8b0:151:1:3cd3:cd67:fafa:3d78]) by mx1.freebsd.org (Postfix) with ESMTP id AEDE08FC13 for ; Fri, 27 Jan 2012 17:45:13 +0000 (UTC) Received: from seedling.black-earth.co.uk (seedling.black-earth.co.uk [IPv6:2001:8b0:151:1:fa1e:dfff:feda:c0bb]) (authenticated bits=0) by smtp.infracaninophile.co.uk (8.14.5/8.14.5) with ESMTP id q0RHjAUK049538 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Fri, 27 Jan 2012 17:45:10 GMT (envelope-from m.seaman@infracaninophile.co.uk) X-DKIM: OpenDKIM Filter v2.4.3 smtp.infracaninophile.co.uk q0RHjAUK049538 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=infracaninophile.co.uk; s=201001-infracaninophile; t=1327686310; bh=iM5X+3MyEDSOJajvjXym1qskE6+lL+KAK9x9e3HXWjE=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type; b=Moq3sDbMoPHiXmxnJldNciCfHld0nlF1aQlFHI7/+PKg4ElrxgKPDsTSbE/DNr971 E3ET1epCyB8Tw0tdpUttrscp5iH8Zn+qCOrZGJRnzif3MDvwY9fXtcIfj/20tQQE0D T4qvz8qCFwHOXhL9OPhxSLQo3/H/x8TUQP0W4INU= Message-ID: <4F22E29F.8080602@infracaninophile.co.uk> Date: Fri, 27 Jan 2012 17:45:03 +0000 From: Matthew Seaman User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0) Gecko/20111222 Thunderbird/9.0.1 MIME-Version: 1.0 To: Chris Rees References: <4F22CB51.6070507@infracaninophile.co.uk> In-Reply-To: X-Enigmail-Version: 1.3.4 OpenPGP: id=60AE908C Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigE75FC7B7F7D247EA208E8CF1" X-Virus-Scanned: clamav-milter 0.97.3 at lucid-nonsense.infracaninophile.co.uk X-Virus-Status: Clean X-Spam-Status: No, score=-2.7 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on lucid-nonsense.infracaninophile.co.uk Cc: freebsd-ports Subject: Re: BSD make -- Malformed conditional X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jan 2012 17:45:14 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigE75FC7B7F7D247EA208E8CF1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 27/01/2012 16:51, Chris Rees wrote: >> .for item in ${LIST} >> > .if ${item} =3D=3D "this" # Ooops > You shouldn't use quotes either. I think that not quoting might be better style, but it's not the typical usage in make(1). There are quite a few contrary examples in the ports: % < /tmp/ports-makefiles xargs grep '} =3D=3D "' | wc -l 1674 % < /tmp/ports-makefiles xargs grep '} =3D=3D [^"]' | wc -l 531 Cheers, Matthew --=20 Dr Matthew J Seaman MA, D.Phil. 7 Priory Courtyard Flat 3 PGP: http://www.infracaninophile.co.uk/pgpkey Ramsgate JID: matthew@infracaninophile.co.uk Kent, CT11 9PW --------------enigE75FC7B7F7D247EA208E8CF1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.16 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk8i4qUACgkQ8Mjk52CukIxz5ACcC+80VP6N5/KN1bK4WtgwfWHo nSoAnRJ2TOkZIRtDY0bX/HacKwrqiGx/ =757C -----END PGP SIGNATURE----- --------------enigE75FC7B7F7D247EA208E8CF1--