Date: Fri, 28 Jun 2019 23:56:27 +0200 From: Jan Beich <jbeich@FreeBSD.org> To: Steve Wills <swills@FreeBSD.org> Cc: gecko@FreeBSD.org Subject: Re: Firefox and GTK2 Message-ID: <sgrt-1iic-wny@FreeBSD.org> In-Reply-To: <5d74ebf9-49cd-04bc-d6b5-aa156491f29f@FreeBSD.org> (Steve Wills's message of "Fri, 28 Jun 2019 16:15:40 -0400") References: <7536c5cf-f8a0-fe5c-661f-b7909b9d57aa@FreeBSD.org> <y31m-acgi-wny@FreeBSD.org> <491275b9-47ef-58b4-ab0c-bdaf1bed13b4@FreeBSD.org> <tvc9-352i-wny@FreeBSD.org> <5d74ebf9-49cd-04bc-d6b5-aa156491f29f@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Steve Wills <swills@FreeBSD.org> writes: > Hi, > > On 6/28/19 3:03 PM, Jan Beich wrote: >> Steve Wills <swills@FreeBSD.org> writes: >> > [snip] >> >> www/firefox only directly loads libcanberra.so.0. > > Right, so we can have libcanberra use gtk2 or gtk3. > >> What actually depends >> on -gtk3 slave? For one, x11-toolkits/gtk30 dropped it since 3.18.0. >> >> https://searchfox.org/mozilla-release/rev/be9f154873f1/widget/gtk/nsSound.cpp#159 >> https://gitlab.gnome.org/GNOME/gtk/commit/7439a7efda25 > > It's not about gtk using libcanberra, it's about which gtk is used by > libcanberra. How does libcanberra decide which gtk to use? > >> $ strings /usr/local/lib/libcanberra.so | fgrep gtk3 >> $ strings /usr/local/lib/libcanberra-gtk.so | fgrep gtk3 >> > > Those two files are from the package of libcanberra that depends on > gtk2, so I wouldn't expect them to depend on gtk3. That's the point. I couldn't find where libcanberra depends on gtk3. It's probably Gtk that calls into libcanberra. If so then every gtk30 consumer that depends on libcanberra also needs libcanberra-gtk3. $ strings /usr/local/lib/gtk-2.0/modules/libcanberra-gtk-module.so | fgrep libcanberra libcanberra.so.0 libcanberra-gtk.so.0 libcanberra-gtk-module.so $ strings /usr/local/lib/gtk-3.0/modules/libcanberra-gtk-module.so | fgrep libcanberra libcanberra.so.0 libcanberra-gtk3.so.0 libcanberra-gtk3-module.so >> GTK3 is still optional in www/seamonkey and not supported in www/palemoon. > > Maybe the libcanberra dep could be moved out of bsd.gecko.mk and into > the ports? Right. To Mk/Uses/gnome.mk where USE_GNOME=canberra can decide whether to pull -gtk3 slave or not.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?sgrt-1iic-wny>