Date: Wed, 16 Apr 2003 20:38:46 +0200 From: John Hay <jhay@icomtek.csir.co.za> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/wl if_wl.c Message-ID: <20030416183846.GA41630@zibbi.icomtek.csir.co.za> In-Reply-To: <XFMail.20030416140625.jhb@FreeBSD.org> References: <200304161742.h3GHgc0l085079@repoman.freebsd.org> <XFMail.20030416140625.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Apr 16, 2003 at 02:06:25PM -0400, John Baldwin wrote: > > On 16-Apr-2003 John Hay wrote: > > jhay 2003/04/16 10:42:38 PDT > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/wl if_wl.c > > Log: > > Add locking and remove all the spl() calls. > > Note that some of the spl calls covered structures other than > just the softc. I'd prefer that we leave spl calls in until > all the structures they cover are locked. Ok, should I put them all back? Or just the ones being used as interrupt disablers? And what about the places where there should have been splx()es but weren't? John -- John Hay -- John.Hay@icomtek.csir.co.za / jhay@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030416183846.GA41630>