From owner-freebsd-bugs@freebsd.org Sat Jun 17 12:18:07 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3E84ABF9AFF for ; Sat, 17 Jun 2017 12:18:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2C7E267952 for ; Sat, 17 Jun 2017 12:18:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5HCI7dn056192 for ; Sat, 17 Jun 2017 12:18:07 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 220078] [patch] [panic] [ipfw] repeatable kernel panic due to unlocked INADDR_TO_IFP usage Date: Sat, 17 Jun 2017 12:18:07 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: eugen@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Jun 2017 12:18:07 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220078 Bug ID: 220078 Summary: [patch] [panic] [ipfw] repeatable kernel panic due to unlocked INADDR_TO_IFP usage Product: Base System Version: 11.0-STABLE Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Some People Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: eugen@freebsd.org Keywords: patch Created attachment 183567 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D183567&action= =3Dedit lock access to INADDR_TO_IFP in the ipfw There are several places in kernel sources where code performs unlocked acc= ess to the hash of host's IP addresses. If adresses change often enough, a panic may occur. For example, part of kgdb script of latest panic of my mpd server: 1642 case O_IP_DST_ME: 1643 if (is_ipv4) { 1644 struct ifnet *tif; 1645 1646 INADDR_TO_IFP(dst_ip, tif); (kgdb) p ia $3 =3D (struct in_ifaddr *) 0xdeadc0dedeadc0de Attached patches add needed locking to several such places including ipfw. --=20 You are receiving this mail because: You are the assignee for the bug.=