From owner-p4-projects@FreeBSD.ORG  Mon Aug 11 21:18:36 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id B6A231065674; Mon, 11 Aug 2008 21:18:36 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7A151106566B
	for <perforce@FreeBSD.org>; Mon, 11 Aug 2008 21:18:36 +0000 (UTC)
	(envelope-from snb@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 4E1538FC14
	for <perforce@FreeBSD.org>; Mon, 11 Aug 2008 21:18:36 +0000 (UTC)
	(envelope-from snb@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.2/8.14.2) with ESMTP id m7BLIaW1085119
	for <perforce@FreeBSD.org>; Mon, 11 Aug 2008 21:18:36 GMT
	(envelope-from snb@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.2/8.14.1/Submit) id m7BLIaPh085117
	for perforce@freebsd.org; Mon, 11 Aug 2008 21:18:36 GMT
	(envelope-from snb@FreeBSD.org)
Date: Mon, 11 Aug 2008 21:18:36 GMT
Message-Id: <200808112118.m7BLIaPh085117@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	snb@FreeBSD.org using -f
From: Nick Barkas <snb@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 147184 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Aug 2008 21:18:37 -0000

http://perforce.freebsd.org/chv.cgi?CH=147184

Change 147184 by snb@snb_toro on 2008/08/11 21:18:31

	It's definitely a good idea to unlock the dirhash if we aren't deleting
	       it.

Affected files ...

.. //depot/projects/soc2008/snb-dirhash/sys-ufs-ufs/ufs_dirhash.c#9 edit

Differences ...

==== //depot/projects/soc2008/snb-dirhash/sys-ufs-ufs/ufs_dirhash.c#9 (text+ko) ====

@@ -1193,6 +1193,9 @@
 			continue;
 		if (time_second - dh->dh_lastused > ufs_dirhashreclaimage)
 			memfreed += ufsdirhash_destroy(dh);
+		/* Unlock if we didn't delete the dirhash */
+		else
+			lockmgr(&dh->dh_lock, LK_RELEASE, 0);
 	}
 	
 	/*