From owner-freebsd-arch@FreeBSD.ORG Thu Apr 1 14:40:44 2010 Return-Path: Delivered-To: freebsd-arch@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1218C106564A; Thu, 1 Apr 2010 14:40:44 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id C305E8FC23; Thu, 1 Apr 2010 14:40:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o31ETuWA017601; Thu, 1 Apr 2010 08:29:56 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Thu, 01 Apr 2010 08:30:02 -0600 (MDT) Message-Id: <20100401.083002.62409427308980027.imp@bsdimp.com> To: Alexander@Leidinger.net From: "M. Warner Losh" In-Reply-To: <20100401133310.194173uurnj5nq4g@webmail.leidinger.net> References: <20100327101846.5b4d6b18@ernst.jennejohn.org> <20100330143824.252520tulyv7bxes@webmail.leidinger.net> <20100401133310.194173uurnj5nq4g@webmail.leidinger.net> X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: rwatson@FreeBSD.org, gary.jennejohn@freenet.de, freebsd-arch@FreeBSD.org Subject: Re: CTF patch for testing/review X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2010 14:40:44 -0000 In message: <20100401133310.194173uurnj5nq4g@webmail.leidinger.net> Alexander Leidinger writes: : Quoting Alexander Leidinger (from Tue, 30 : Mar 2010 14:38:24 +0200): : : > http://www.leidinger.net/test/ctf4.diff : > : > Changes to previous one: : > - added @ to hide the CTF stuff : > - man-page (to test: "groff -mdoc -Tascii /path/to/build.7 | less") : > : > Someone with mdoc-fu should have a look if I got it right, the others : > please have a look if the place in the man-page pleases you. : > : > The changed commit log would be: : > ---snip--- : > WITH_CTF can now be specified in src.conf (not recommended, there : > are some problems with static executables), make.conf (would also : > affect ports which do not use GNU make and do not override the : > compile targets) or in the kernel config (via "makeoptions : > WITH_CTF=yes"). : > : > Additional (related) changes: : > - propagate WITH_CTF to module builds : > - do not add -g to the linker flags, it's a noop there anyway : > (at least according to the man page of ld) : > - do not add -g to CFLAGS unconditionally : > we need to have a look if it is really needed (IMO not) or if there : > is a way to add it only when WITH_CTF is used : > : > Note: ctfconvert / ctfmerge lines will not appear in the build output, : > to protect the innocent (those which do not build with WITH_CTF would : > see the shell-test and may think WITH_CTF is used). : > : > Reviewed by: imp, jhb, scottl (earlier version) : > Discussed on: arch@ : > ---snip--- : > : > What about Friday morning (GMT+2) for a commit date (if nobody : > complains): not long enough for review or is it OK? : : Nobody complained so far, so I try to commit this tomorrow. Note: the : date in the man page will be bumped (in cases someone notices that : this is missing in the patch). Go for it. Warner