Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 08 Jun 2009 16:49:36 -0700
From:      Xin LI <delphij@delphij.net>
To:        FreeBSD Tinderbox <tinderbox@freebsd.org>
Cc:        net@freebsd.org, current@freebsd.org, sparc64@freebsd.org
Subject:   Re: [head tinderbox] failure on sparc64/sparc64
Message-ID:  <4A2DA390.3090704@delphij.net>
In-Reply-To: <20090608224516.547F17302F@freebsd-current.sentex.ca>
References:  <20090608224516.547F17302F@freebsd-current.sentex.ca>

next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------080305080905050101040406
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

FreeBSD Tinderbox wrote:
> cc1: warnings being treated as errors
> /src/sys/net/if_gif.c: In function 'gif_ioctl':
> /src/sys/net/if_gif.c:918: warning: cast to pointer from integer of different size
> *** Error code 1
> 
> Stop in /obj/sparc64/src/sys/LINT.
> *** Error code 1

The attached patch should fix this, any objections?

Cheers,
- --
Xin LI <delphij@delphij.net>	http://www.delphij.net/
FreeBSD - The Power to Serve!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.11 (FreeBSD)

iEYEARECAAYFAkoto48ACgkQi+vbBBjt66C98ACgvgafjQZ/MU01V8ftN6ZI9/1U
xB0AoKZipqyI0JYmBkMGNsEEYp8A0VVl
=3o5u
-----END PGP SIGNATURE-----

--------------080305080905050101040406
Content-Type: text/plain;
 name="if_gif.c.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="if_gif.c.diff"

Index: if_gif.c
===================================================================
--- if_gif.c	(revision 193731)
+++ if_gif.c	(working copy)
@@ -912,10 +912,10 @@
 	case GIFSOPTS:
 		if ((error = priv_check(curthread, PRIV_NET_GIF)) != 0)
 			break;
-		if ((error = copyin(&options, &sc->gif_options,
-				sizeof(sc->gif_options)))) {
+		if ((error = copyin(ifr->ifr_data, &options,
+				sizeof(options)))) {
 			if ((options | GIF_FULLOPTS) == GIF_FULLOPTS)
-				ifr->ifr_data = (caddr_t)options;
+				sc->gif_options = options;
 			else
 				error = EINVAL;
 		}

--------------080305080905050101040406--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A2DA390.3090704>