From owner-svn-src-head@FreeBSD.ORG  Fri Jul 18 18:25:12 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 75C028AB;
 Fri, 18 Jul 2014 18:25:12 +0000 (UTC)
Received: from alto.onthenet.com.au (alto.OntheNet.com.au [203.13.68.12])
 by mx1.freebsd.org (Postfix) with ESMTP id 35A4C20B9;
 Fri, 18 Jul 2014 18:25:11 +0000 (UTC)
Received: from dommail.onthenet.com.au (dommail.OntheNet.com.au [203.13.70.57])
 by alto.onthenet.com.au (Postfix) with ESMTPS id 3547B125B1;
 Sat, 19 Jul 2014 04:25:10 +1000 (EST)
Received: from Peter-Grehans-MacBook-Pro-2.local ([64.245.0.210])
 by dommail.onthenet.com.au (MOS 4.4.4-GA)
 with ESMTP id BXF04014 (AUTH peterg@ptree32.com.au);
 Sat, 19 Jul 2014 04:25:09 +1000
Message-ID: <53C96683.9070902@freebsd.org>
Date: Fri, 18 Jul 2014 11:25:07 -0700
From: Peter Grehan <grehan@freebsd.org>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6;
 rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version: 1.0
To: Adrian Chadd <adrian@freebsd.org>
Subject: Re: svn commit: r268837 - head/sys/netinet
References: <201407180822.s6I8MD5a023838@svn.freebsd.org>	<53C94F61.5020706@freebsd.org>
 <CAJ-VmonRRZPi+RkGQk25xrXGf9BOhHXvAVhRWse+fXKduoJ19g@mail.gmail.com>
In-Reply-To: <CAJ-VmonRRZPi+RkGQk25xrXGf9BOhHXvAVhRWse+fXKduoJ19g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Jul 2014 18:25:12 -0000

Hi Adrian,

> Hah! I wonder why the key from the T3 NIC that Robert committed was so
> .. terrible then.
>
> Are you saying that the actual byte order is totally reversed, or just endian?

  The 32-bit word order of your array is reversed. The last 4 bytes 
should be the first, etc. Have a look at the values in the Microsoft spec.

> I think that was Roberts main concern with using a randomised key at
> startup. It sounds Netapp have already done a lot of the work that I
> was thinking about in the back of my mind - I'll add that to my TODO
> list so we can write a random key generation function at boot time.

  It's still useful to select the Microsoft value e.g. with a tunable, 
since it allows easy verification when folk are implementing RSS.

later,

Peter.