From owner-freebsd-current@freebsd.org  Sun Jul 15 17:17:39 2018
Return-Path: <owner-freebsd-current@freebsd.org>
Delivered-To: freebsd-current@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 86E8F1047757
 for <freebsd-current@mailman.ysv.freebsd.org>;
 Sun, 15 Jul 2018 17:17:39 +0000 (UTC)
 (envelope-from sgk@troutmask.apl.washington.edu)
Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu
 [128.95.76.21])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "troutmask", Issuer "troutmask" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 185BA8F626;
 Sun, 15 Jul 2018 17:17:39 +0000 (UTC)
 (envelope-from sgk@troutmask.apl.washington.edu)
Received: from troutmask.apl.washington.edu (localhost [127.0.0.1])
 by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id w6FHHbhY031212
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Sun, 15 Jul 2018 10:17:37 -0700 (PDT)
 (envelope-from sgk@troutmask.apl.washington.edu)
Received: (from sgk@localhost)
 by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id w6FHHbkn031211;
 Sun, 15 Jul 2018 10:17:37 -0700 (PDT) (envelope-from sgk)
Date: Sun, 15 Jul 2018 10:17:37 -0700
From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Ian Lepore <ian@freebsd.org>
Cc: freebsd-current@freebsd.org
Subject: Re: [PATCH] Recent libm additions
Message-ID: <20180715171737.GA31164@troutmask.apl.washington.edu>
Reply-To: sgk@troutmask.apl.washington.edu
References: <20180715150638.GA30154@troutmask.apl.washington.edu>
 <1531674041.26036.1.camel@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1531674041.26036.1.camel@freebsd.org>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Jul 2018 17:17:39 -0000

On Sun, Jul 15, 2018 at 11:00:41AM -0600, Ian Lepore wrote:
> On Sun, 2018-07-15 at 08:06 -0700, Steve Kargl wrote:
> > Index: ld80/e_powl.c
> > ===================================================================
> > --- ld80/e_powl.c	(revision 336304)
> > +++ ld80/e_powl.c	(working copy)
> > @@ -77,6 +77,7 @@
> >  #include 
> >  
> >  #include "math_private.h"
> > +#include "polevll.c"
> 
> If a file contains inline function definitions and is intended only to
> be included into another file and not compiled separately, shouldn't
> its name be spelled polevll.h ?
> 

Well, actually, the functions in polevll.c should have been copied
into ld80/e_powl.c, and polevall.c should never have been committed.
Unfortunately, the code was not reviewed for correctness.  I've
made the minimum changes to address the two issues I've noted.
Feel free to either copy the functions and delete the polevall.c
or rename it.

-- 
Steve