Date: Wed, 23 Jun 2010 19:19:38 +0000 From: "Philip M. Gollucci" <pgollucci@p6m7g8.com> To: Doug Barton <dougb@FreeBSD.org> Cc: David DEMELIER <demelier.david@gmail.com>, freebsd-ports@FreeBSD.org Subject: Re: New pkg-message[.in] guideline idea Message-ID: <4C225E4A.8010607@p6m7g8.com> In-Reply-To: <4C225D42.4040603@FreeBSD.org> References: <AANLkTimAhMpVuTIj10XKW65Wl2c6zplyyjD83OO1Y-1I@mail.gmail.com> <20100623144021.GC280@atarininja.org> <4C221E32.60400@p6m7g8.com> <4C225D42.4040603@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 06/23/10 19:15, Doug Barton wrote: >> I think we need 2 things: >> > >> > 1) All pkg-message whether .in or not go >> > through the 'sed' that SUB_LIST/PLIST_SUB do. > I like this idea better than forcing them all to be in /files, and I > can't see any reason not to do it. The other benefit is you can carry over the PLIST logic with @comment to conditionalize lines in the message and thus eliminate all that crap from Makefiles. > >> > 2) You collect them in to /var/db/pkg and loop >> > and display at end. >> > >> > As a consequence all formatting should be removed from the individual >> > pkg-message[.in] files and added in #2. > I'm ambivalent about this. My first thought was that the formatting > should happen in step #1. What portmaster does is build each port one at > a time, and it makes a note if a port has a pkg-message. Then it does > what you suggest in #2 by cat'ing them all to $PAGER. However, thinking > more about it I could see how not doing the formatting until step 2 > could work, so however it turns out to be "easiest" should be fine. I believe we are agreeing. I didn't say anything about portmaster/portupgrade. The pkg/make infrastructure needs to do it at the end so that it works via pkg_add, make, or portmaster et al. - -- - ------------------------------------------------------------------------ 1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354 VP Apache Infrastructure; Member, Apache Software Foundation Committer, FreeBSD Foundation Consultant, P6M7G8 Inc. Sr. System Admin, Ridecharge Inc. Work like you don't need the money, love like you'll never get hurt, and dance like nobody's watching. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iD4DBQFMIl5KdbiP+9ubjBwRApYMAJ0ZgYpsSy41WeNNZxKjpgK2HpKdcwCYh54j 7t2X4DuUUkkrAdeLTr2Kiw== =BrZx -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C225E4A.8010607>