From owner-freebsd-current@FreeBSD.ORG Thu Nov 5 11:28:41 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 097F7106566B; Thu, 5 Nov 2009 11:28:41 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (skuns.zoral.com.ua [91.193.166.194]) by mx1.freebsd.org (Postfix) with ESMTP id 6D56C8FC0A; Thu, 5 Nov 2009 11:28:40 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id nA5BSZjh053318 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 5 Nov 2009 13:28:35 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id nA5BSZUG086711; Thu, 5 Nov 2009 13:28:35 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id nA5BSYCF086686; Thu, 5 Nov 2009 13:28:34 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 5 Nov 2009 13:28:34 +0200 From: Kostik Belousov To: Giovanni Trematerra Message-ID: <20091105112834.GR2331@deviant.kiev.zoral.com.ua> References: <4e6cba830911050302k56bed35aj5ca9fa16379ab325@mail.gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Bi+HF1AHjw0mn3zx" Content-Disposition: inline In-Reply-To: <4e6cba830911050302k56bed35aj5ca9fa16379ab325@mail.gmail.com> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: Attilio Rao , des@des.no, FreeBSD Current Subject: Re: [PATCH] AMD Opteron Rev. E hack X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Nov 2009 11:28:41 -0000 --Bi+HF1AHjw0mn3zx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 05, 2009 at 12:02:39PM +0100, Giovanni Trematerra wrote: > Hi, > I have a quick and dirty patch to address the problem as discussed on > commit r198868 in svn-src-head@ > I introduced BROKEN_OPTERON_E kernel option for i386/amd64 arch. > The patch isn't tested yet, I only successfully compiled on i386. > Can you let me know if the patch is on the right direction to resolve the issue? > style(9) tips are welcomed. I think there is no much sense in printing that hack in unused; instead, you should print info when option is enabled and vulnerable CPU is detected. Aren't atomic_readandclear need the same workaround ? It would be much easier to read the patch if you generated it with analog of "svn diff -x -p" for your VCS. --Bi+HF1AHjw0mn3zx Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkrytuIACgkQC3+MBN1Mb4gcAwCeLgX6gTbM3CP7fSNxc82yjP95 PFkAnRWduCsbqL7cdEs31CURhh6RIv0N =GUh7 -----END PGP SIGNATURE----- --Bi+HF1AHjw0mn3zx--