From owner-cvs-src@FreeBSD.ORG Thu Sep 11 08:12:20 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D4AB016A4C0; Thu, 11 Sep 2003 08:12:20 -0700 (PDT) Received: from pittgoth.com (14.zlnp1.xdsl.nauticom.net [209.195.149.111]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8982E43FD7; Thu, 11 Sep 2003 08:12:18 -0700 (PDT) (envelope-from trhodes@FreeBSD.org) Received: from localhost (acs-24-154-239-225.zoominternet.net [24.154.239.225]) by pittgoth.com (8.12.9/8.12.9) with SMTP id h8BFCHvd031222; Thu, 11 Sep 2003 11:12:17 -0400 (EDT) (envelope-from trhodes@FreeBSD.org) Date: Thu, 11 Sep 2003 10:29:46 -0400 From: Tom Rhodes To: Maxime Henrion Message-Id: <20030911102946.5c1639fe.trhodes@FreeBSD.org> In-Reply-To: <20030911145510.GB83361@elvis.mu.org> References: <200309102055.h8AKtA7N027631@repoman.freebsd.org> <20030911062400.GA83361@elvis.mu.org> <20030911000107.B38429@12-234-22-23.pyvrag.nggov.pbz> <20030911093434.18760596.trhodes@FreeBSD.org> <20030911145510.GB83361@elvis.mu.org> X-Mailer: Sylpheed version 0.9.3claws (GTK+ 1.2.10; i386-portbld-freebsd5.1) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: Doug Barton cc: cvs-all@FreeBSD.org cc: src-committers@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/sysinstall config.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Sep 2003 15:12:21 -0000 On Thu, 11 Sep 2003 16:55:10 +0200 Maxime Henrion wrote: > Tom Rhodes wrote: > > On Thu, 11 Sep 2003 00:06:16 -0700 (PDT) > > Doug Barton wrote: > > > > > On Thu, 11 Sep 2003, Maxime Henrion wrote: > > > > > > > Tom Rhodes wrote: > > > > > trhodes 2003/09/10 13:55:10 PDT > > > > > > > > > > FreeBSD src repository > > > > > > > > > > Modified files: > > > > > usr.sbin/sysinstall config.c > > > > > Log: > > > > > With the exim port upgrade, modify sysinstall(8): > > > > > > > > > > - Add 'enable_exim="YES"' to rc.conf(5) > > > > [...] > > > > > > > > All other rc.conf(5) options that enable services are of the form > > > > _enable. Why the difference here? > > > > > > Yeah, this is evil and should be changed. There is not guarantee that > > > this won't totally break someday. > > > > > > Quoting Simon since he already answered this: > > > > It is actually not an issue, since it was just a typo in Tom's commit > > message, not the actual code. The actual code is : > > > > --- src/usr.sbin/sysinstall/config.c 2003/08/03 05:55:21 1.212 > > +++ src/usr.sbin/sysinstall/config.c 2003/09/10 20:55:09 1.213 > > [CUT] > > + variable_set2("exim_enable", "YES", 1); > > > > > > Is there still a problem Doug, Maxime? I can do a forced commit, > > or when I commit the change being discussed with Ceri I could make > > a comment about the previous revision. > > No problems at all. I should probably have checked in the code before > sending this e-mail, and I actually did, but I read wrong - probably > because it was early in the morning :-). It might be a good idea to do > a forced commit, though I don't think it's really needed for such a > small typo. Well, I agree that a forced commit for a small typo like this is rather worthless. However, I'm committing to this area soon per my conversation with Ceri. -- Tom Rhodes