Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 24 Mar 2010 15:17:59 -0700
From:      Greg Lewis <glewis@eyesbeyond.com>
To:        gahr@FreeBSD.org
Cc:        Koop Mast <kwm@FreeBSD.org>, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/www/webkit-gtk2 Makefile ports/www/webkit-gtk2/files patch-JavaScriptCore-runtime_JSValue.h
Message-ID:  <20100324221759.GA26404@misty.eyesbeyond.com>
In-Reply-To: <20100324155905.GB29421@gahrfit.gahr.ch>
References:  <201003241551.o2OFpj9i044724@repoman.freebsd.org> <1269446394.17060.1.camel@headache.rainbow-runner.nl> <20100324155905.GB29421@gahrfit.gahr.ch>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 24, 2010 at 04:59:05PM +0100, Pietro Cerutti wrote:
> On 2010-Mar-24, 16:59, Koop Mast wrote:
> > On Wed, 2010-03-24 at 15:51 +0000, Pietro Cerutti wrote:
> > > gahr        2010-03-24 15:51:45 UTC
> > > 
> > >   FreeBSD ports repository
> > > 
> > >   Modified files:
> > >     www/webkit-gtk2      Makefile 
> > >   Added files:
> > >     www/webkit-gtk2/files patch-JavaScriptCore-runtime_JSValue.h 
> > >   Log:
> > >   - Fix build on sparc64
> > 
> > Who approved this? Btw ia64 fails with the same error.
> 
> Since when one needs an approval for UNBREAK commits? I have no access
> to ia64 machines.

Good catch.  Shouldn't you use _LP64 or something similar rather than
specifically __sparc64__?  It seems like the former would also fix
other platforms (e.g. ia64).

Caveat: I haven't got a machine I can check whether we define _LP64 on or not.

-- 
Greg Lewis                          Email   : glewis@eyesbeyond.com
Eyes Beyond                         Web     : http://www.eyesbeyond.com
Information Technology              FreeBSD : glewis@FreeBSD.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100324221759.GA26404>