Date: Tue, 14 Jun 2005 19:36:00 -0700 From: "David O'Brien" <obrien@freebsd.org> To: Maxim Konovalov <maxim@macomnet.ru> Cc: freebsd-current@freebsd.org, Ed Maste <emaste@phaedrus.sandvine.ca> Subject: Re: savecore(8) increments /var/crash/bounds on each boot Message-ID: <20050615023600.GA20721@dragon.NUXI.org> In-Reply-To: <20050614235132.L76669@mp2.macomnet.net> References: <20050613192308.GA87640@sandvine.com> <20050614082039.GA2038@dragon.NUXI.org> <20050614224704.Y75797@mp2.macomnet.net> <20050614190854.GA12928@dragon.NUXI.org> <20050614235132.L76669@mp2.macomnet.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jun 15, 2005 at 12:10:05AM +0400, Maxim Konovalov wrote: > On Tue, 14 Jun 2005, 12:08-0700, David O'Brien wrote: > > > On Tue, Jun 14, 2005 at 10:49:44PM +0400, Maxim Konovalov wrote: > > > On Tue, 14 Jun 2005, 01:20-0700, David O'Brien wrote: > > > > > > > On Mon, Jun 13, 2005 at 03:23:08PM -0400, Ed Maste wrote: > > > > > I notice that as of sbin/savecore/savecore.c 1.72 and in 5.4-RELEASE > > > > > savecore increments the number in /var/crash/bounds on each boot, > > > > > regardless of whether it rebooted due to panic or was a clean shutdown. > > > > > Is this the desired behaviour or an unintentional side effect? > > > > > > > > It is an unintentional side affect. If I wasn't constantly experiencing > > > > kernel landminds every time I sit down to do major FreeBSD, I would have > > > > gotten to this issue. > > > > > > I am going to ask re@ for permission to commit the fix if nobody beats > > > me. > > > > Are you sure its correct? Have you tested it with say bounds != 0 and a > > few core dumps in /var/crash? > > No problems so far: Do you understand the fix? How does lying in printheader() fix anything? Moving the call to getbounds() back to the original location is the "fix" but then it negates -vv. We shouldn't lie in printheader(). -- -- David (obrien@FreeBSD.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050615023600.GA20721>