Date: Sun, 31 Dec 2017 14:37:32 -0800 From: Nathan Whitehorn <nwhitehorn@freebsd.org> To: freebsd-current@freebsd.org Subject: Re: SVN r327444 breaks current build Message-ID: <b5b18d88-3a66-1d19-f8ab-61b1a63ec21f@freebsd.org> In-Reply-To: <20171231222235.GA62313@bluezbox.com> References: <0b8f0e34-7a39-fd59-7f66-b55f1af0e920@protected-networks.net> <20171231222235.GA62313@bluezbox.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/31/17 14:22, Oleksandr Tymoshenko wrote: > Michael Butler (imb@protected-networks.net) wrote: >> Building /usr/obj/usr/src/amd64.amd64/sys/VM01/vt_font_default.o >> --- vt_termcolors.o --- >> /usr/src/sys/dev/vt/colors/vt_termcolors.c:158:55: error: too many >> arguments to function call, expected 4, have 5 >> if (vt_parse_rgb_triplet(rgb, strlen(rgb), &r, >> &g, &b) == 0) { >> ~~~~~~~~~~~~~~~~~~~~ >> ^~ >> /usr/src/sys/dev/vt/colors/vt_termcolors.c:77:1: note: >> 'vt_parse_rgb_triplet' declared here >> static int >> ^ >> 1 error generated. >> *** [vt_termcolors.o] Error code 1 >> >> <sigh> .. second time today a commit wasn't tested before commit :-( >> >> imb > Should be fixed in r327449. It was a sloppy job, I was making iterative > improvements to the original patch following review feedback and used > out-of-tree testcases for actual testing. I appologize for the breakage. > Still broken with GCC. /usr/src/sys/dev/vt/colors/vt_termcolors.c:148: warning: function declaration isn't a prototype [-Wstrict-prototypes] *** [vt_termcolors.o] Error code 1 -Nathan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b5b18d88-3a66-1d19-f8ab-61b1a63ec21f>