Date: Mon, 6 May 2013 15:20:02 GMT From: Gang Hu <henry.hu.sh@gmail.com> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/178269: [PATCH] Remove checks for get_pidfile_from_conf function Message-ID: <201305061520.r46FK2eG075737@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/178269; it has been noted by GNATS. From: Gang Hu <henry.hu.sh@gmail.com> To: Chris Rees <utisoft@gmail.com> Cc: jarrod@downtools.com.au, Florian Smeets <flo@freebsd.org>, "bug-followup@freebsd.org" <bug-followup@freebsd.org> Subject: Re: ports/178269: [PATCH] Remove checks for get_pidfile_from_conf function Date: Mon, 6 May 2013 11:17:58 -0400 --14dae9340ff5e4162804dc0e35c8 Content-Type: text/plain; charset=ISO-8859-1 I'm fine with the get_pidfile_from_conf change. But I'm not sure whether the style changes are needed. For the quotes, with a quick grep in /etc/rc.d, it seems like that the standard ones have them. Maybe better leave them as-is. On Tue, Apr 30, 2013 at 5:52 PM, Chris Rees <utisoft@gmail.com> wrote: > Hi Jarrod, Florian and Henry, > > Please take note of ports/178269, containing a totally trivial change > to the rc scripts of net-mgmt/nrpe2, sysutils/munin-node and x11/slim. > > I'm trying to reduce the apparent fear around the use of > get_pidfile_from_conf, so this simplification should help. > > Are the changes OK with you? > > Chris > -- Cheers, Henry --14dae9340ff5e4162804dc0e35c8 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">I'm fine with the get_pidfile_from_conf change. But I&= #39;m not sure whether the style changes are needed.<br>For the quotes, wit= h a quick grep in /etc/rc.d, it seems like that the standard ones have them= . Maybe better leave them as-is.<br> </div><div class=3D"gmail_extra"><br><br><div class=3D"gmail_quote">On Tue,= Apr 30, 2013 at 5:52 PM, Chris Rees <span dir=3D"ltr"><<a href=3D"mailt= o:utisoft@gmail.com" target=3D"_blank">utisoft@gmail.com</a>></span> wro= te:<br> <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex">Hi Jarrod, Florian and Henry,<br> <br> Please take note of ports/178269, containing a totally trivial change<br> to the rc scripts of net-mgmt/nrpe2, sysutils/munin-node and x11/slim.<br> <br> I'm trying to reduce the apparent fear around the use of<br> get_pidfile_from_conf, so this simplification should help.<br> <br> Are the changes OK with you?<br> <span class=3D"HOEnZb"><font color=3D"#888888"><br> Chris<br> </font></span></blockquote></div><br><br clear=3D"all"><br>-- <br>Cheers,<b= r>Henry </div> --14dae9340ff5e4162804dc0e35c8--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201305061520.r46FK2eG075737>