Date: Sun, 14 Aug 2016 06:06:39 +0000 From: Glen Barber <gjb@FreeBSD.org> To: Conrad Meyer <cem@freebsd.org> Cc: Juli Mallett <juli@clockworksquid.com>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-svnadmin@freebsd.org, svnadm@freebsd.org Subject: Re: svn commit: r304070 - svnadmin/conf Message-ID: <20160814060639.GG11079@FreeBSD.org> In-Reply-To: <CAG6CVpVHaGH-%2Bh9%2B%2BfZiBRzdghiecpoX6WcRTxfdaY2iVoB%2BrQ@mail.gmail.com> References: <201608140435.u7E4Z4Fm022554@repo.freebsd.org> <CAG6CVpXoAtpEva0=H-tLtJLnk2gDRo-8=0cRuV7jghXdJq8fyw@mail.gmail.com> <20160814044723.GF11079@FreeBSD.org> <CACVs6=-HUP=Mwt6%2Bu3epDHfOF4L2mibTvdN0fyc3bbOeC4%2Bj8g@mail.gmail.com> <CAG6CVpVHaGH-%2Bh9%2B%2BfZiBRzdghiecpoX6WcRTxfdaY2iVoB%2BrQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--GN/IAAAoV4GJoJGS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 13, 2016 at 10:51:59PM -0700, Conrad Meyer wrote: > On Sat, Aug 13, 2016 at 10:48 PM, Juli Mallett <juli@clockworksquid.com> = wrote: > > On Sat, Aug 13, 2016 at 9:47 PM, Glen Barber <gjb@freebsd.org> wrote: > >> Quoting the original request to remove this, which I tend to agree: > >> > >> -------------------------- begin quoted text -------------------------= -- > >> The svn commit mail script uses some form of 'diff -p' (or 'svn diff > >> -x-p') to include function names at the top of each hunk. The problem > >> is that diff gets it wrong more often than not, especially (but not > >> only) when functions are added or renamed, or outside a funciton, or = in > >> headers, or in code that makes heavy use of macros, or in files that > >> aren't C-like source code: shell scripts, man pages, Makefiles... All > >> it really does is clutter up the patch and mislead the reader. > >> --------------------------- end quoted text --------------------------= -- > > > > :( > > > > I'm deeply skeptical that the described conditions add up to "more > > often than not," and that tangible harm is done in those cases, > > outweighing benefit added in the other, ostensibly rarer, case > > (changes in ordinary C source files, which are actually fairly > > abundant in FreeBSD.) >=20 > Exactly. Yes, it gets it wrong sometimes. But not enough to make it > more harmful than beneficial. >=20 Reverted. I won't deal with this topic further. Glen --GN/IAAAoV4GJoJGS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXsApvAAoJEAMUWKVHj+KTGHwP/14XNX/9qwt5ZV6YRJA3JywA DvztMwltIvKI7G3ki5ZEwouOR40e+Mq57cAfVVlQVCY56wckflQoOdIyWi+KW26W b2WxQ5ZZApZYSRw2KPYJcL9i7fxih5sbE+pfJq77WOj9Uze7jQ1CblLHavFwTjee VGe+ePH5uGNUY0KBfgmR0SHgrGWWzS8SHB2GIZzG9CPnqGLkfaSdeMlBMcw9CBc1 1asX+1HkiN4B0oogCnYQSWcLsNCl5BhDhG3gtZxSfssxJZnh4qxND9x29wKKaZsz NiUYylpYWFJ3Ub39Aq4SB7tYmx4uLGI3gctyolp3tkAhcT3MVNgBFX/5uF1rSjaF QTBKqOQNTr5/nhWtCD3SQ07cm7SEnhK2ig87WL+V+vUr0xtbIVcGrYVObFWTKM/N ruGXidTO2rywkWxUqTdn5tiREe3bTAGHKhrkXSGSywhzo1p6fEMThLpf6Ytce+Pe 9x5JqIQERvNClisQjSyBRkxk0H1V5WXFKtdxu/jPHWlzT0TEPNLCvpv+Temhgtmi Yc1EbqdbRvynwfq2FIOKsr+cEx2DjgrCYRiL24p7JnQnOmNb6qVyI8Zy9HyGs2zg oLscvU+oWqUMQSWzkZmo4I3i8wqC4dQZssyDX4Vj8EUkqkqSbdf0/oRcrPYXeCgc sqDvZuU5pL3zjWKBr9kq =ah93 -----END PGP SIGNATURE----- --GN/IAAAoV4GJoJGS--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160814060639.GG11079>