From owner-freebsd-current Wed Dec 2 11:44:37 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id LAA26635 for freebsd-current-outgoing; Wed, 2 Dec 1998 11:44:37 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from cimlogic.com.au (cimlog.lnk.telstra.net [139.130.51.31]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id LAA26630 for ; Wed, 2 Dec 1998 11:44:33 -0800 (PST) (envelope-from jb@cimlogic.com.au) Received: (from jb@localhost) by cimlogic.com.au (8.9.1/8.9.1) id GAA09742; Thu, 3 Dec 1998 06:52:04 +1100 (EST) (envelope-from jb) From: John Birrell Message-Id: <199812021952.GAA09742@cimlogic.com.au> Subject: Re: Uh oh... In-Reply-To: <7403.912601392@zippy.cdrom.com> from "Jordan K. Hubbard" at "Dec 2, 98 04:23:12 am" To: jkh@zippy.cdrom.com (Jordan K. Hubbard) Date: Thu, 3 Dec 1998 06:52:03 +1100 (EST) Cc: jb@cimlogic.com.au, dillon@apollo.backplane.com, current@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL40 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Jordan K. Hubbard wrote: > Hmmm. Just off the top of my head (and my shell wizardry skills are a > bit rusty so please excuse the roughness of this), are you suggesting > something like this: [...] > If so, I'd be interested in seeing a more polished version of the > above committed by somebody in this discussion (it can be me, if > necessary, I'm just giving others ample opportunity for it to be them > instead :-). The "fix" above has some immediate problems with it, > most notably the hardcoded references to awk and sh as well as the > missing ${DESTDIR} in front of /etc/master.passwd and /etc/group. > That's a casualty of the single quotes around awk's command line arg > which would prevent a ${DESTDIR} in the obvious places from expanding, > and I am too tired at the moment to even contemplate the more advanced > shell wizardry required to cons up more suitable arguments to awk. > > .. and I'm sure the perl weenies could easily figure out some way to > do it in even less characters. :-) Yes, however there is the "rule" of not touching the installed system until installworld. I think that mtree should read src/etc/master.passwd and src/etc/group to get the uid/gid values. This avoids the dependency of the hierarchy on awk etc as build tools. The new mtree version would need to be bootstrapped early like make is. The installworld step should do the ${DESTDIR}/etc update (also adding any missing .conf files too). -- John Birrell - jb@cimlogic.com.au; jb@freebsd.org http://www.cimlogic.com.au/ CIMlogic Pty Ltd, GPO Box 117A, Melbourne Vic 3001, Australia +61 418 353 137 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message