From owner-freebsd-current@FreeBSD.ORG Wed May 31 15:44:44 2006 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BB17616A436; Wed, 31 May 2006 15:44:44 +0000 (UTC) (envelope-from rodrigc@crodrigues.org) Received: from rwcrmhc13.comcast.net (rwcrmhc13.comcast.net [204.127.192.83]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3821443D53; Wed, 31 May 2006 15:44:44 +0000 (GMT) (envelope-from rodrigc@crodrigues.org) Received: from c-24-147-19-128.hsd1.ma.comcast.net (c-71-233-168-2.hsd1.ma.comcast.net[71.233.168.2](misconfigured sender)) by comcast.net (rwcrmhc13) with ESMTP id <20060531154440m1300foebue>; Wed, 31 May 2006 15:44:40 +0000 Received: from c-24-147-19-128.hsd1.ma.comcast.net (localhost [127.0.0.1]) by c-24-147-19-128.hsd1.ma.comcast.net (8.13.6/8.13.1) with ESMTP id k4VFidoW005615; Wed, 31 May 2006 11:44:39 -0400 (EDT) (envelope-from rodrigc@c-24-147-19-128.hsd1.ma.comcast.net) Received: (from rodrigc@localhost) by c-24-147-19-128.hsd1.ma.comcast.net (8.13.6/8.13.1/Submit) id k4VFidBe005614; Wed, 31 May 2006 11:44:39 -0400 (EDT) (envelope-from rodrigc) Date: Wed, 31 May 2006 11:44:39 -0400 From: Craig Rodrigues To: Joe Marcus Clarke Message-ID: <20060531154439.GA5528@crodrigues.org> References: <1148962081.8820.49.camel@shumai.marcuscom.com> <20060530160405.GA39658@crodrigues.org> <1149006607.94908.5.camel@shumai.marcuscom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1149006607.94908.5.camel@shumai.marcuscom.com> User-Agent: Mutt/1.4.2.1i Cc: current@FreeBSD.org Subject: Re: -CURRENT does not recognize standard mount options X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2006 15:44:46 -0000 On Tue, May 30, 2006 at 12:30:07PM -0400, Joe Marcus Clarke wrote: > Should its kernel backend not support all of those options as well? Or > perhaps global_opts in vfs_mount.c should be updated to support all Can you try this patch? I'm not sure if "force" and "sync" should be global_opts or not because I don't know if they make sense for every FS, but for symmetry with what was in mount_msdosfs before, we can push them into the filesystem code for msdosfs. These inconsistencies between the various mount programs and the various filesystem code is why I've been trying to push towards using a single mount binary, and pushing the mount option parsing into vfs_mount.c and the code for the specific filesystem. We are not quite there yet, but we are a lot closer. > MNT_STDOPTS options since mntopts.h says that these are options all > mounts can understand? Thanks for the follow up. The problem is that comments like that were written with a UFS-centric view. It may not necessarily be true that the various filesystems support all the "STD" mount options. However, if you see something that you think should work, let me know and we can add it to global_opts if it is obvious that it should work for all filesystems, or to the option code for a specific filesystem like msdosfs if the mount option only works on specific filesystems. Index: sys/fs/msdosfs/msdosfs_vfsops.c =================================================================== RCS file: /home/ncvs/src/sys/fs/msdosfs/msdosfs_vfsops.c,v retrieving revision 1.150 diff -u -u -r1.150 msdosfs_vfsops.c --- sys/fs/msdosfs/msdosfs_vfsops.c 26 May 2006 00:32:20 -0000 1.150 +++ sys/fs/msdosfs/msdosfs_vfsops.c 31 May 2006 15:29:51 -0000 @@ -79,7 +79,7 @@ /* List of mount options we support */ static const char *msdosfs_opts[] = { "from", - "export", + "export", "force", "sync", "uid", "gid", "mask", "dirmask", "shortname", "shortnames", "longname", "longnames", "nowin95", "win95", "kiconv", "cs_win", "cs_dos", "cs_local", Index: sbin/mount_msdosfs/mount_msdosfs.c =================================================================== RCS file: /home/ncvs/src/sbin/mount_msdosfs/mount_msdosfs.c,v retrieving revision 1.41 diff -u -u -r1.41 mount_msdosfs.c --- sbin/mount_msdosfs/mount_msdosfs.c 1 Dec 2005 00:18:48 -0000 1.41 +++ sbin/mount_msdosfs/mount_msdosfs.c 31 May 2006 15:30:00 -0000 @@ -59,9 +59,6 @@ static struct mntopt mopts[] = { MOPT_STDOPTS, - MOPT_FORCE, - MOPT_SYNC, - MOPT_UPDATE, MOPT_END }; -- Craig Rodrigues rodrigc@crodrigues.org