From owner-svn-src-head@FreeBSD.ORG Thu Jun 3 13:45:28 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2C1361065674; Thu, 3 Jun 2010 13:45:28 +0000 (UTC) (envelope-from trasz@FreeBSD.org) Received: from svn.freebsd.org (unknown [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 1C4118FC18; Thu, 3 Jun 2010 13:45:28 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o53DjSOO095147; Thu, 3 Jun 2010 13:45:28 GMT (envelope-from trasz@svn.freebsd.org) Received: (from trasz@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o53DjSJB095145; Thu, 3 Jun 2010 13:45:28 GMT (envelope-from trasz@svn.freebsd.org) Message-Id: <201006031345.o53DjSJB095145@svn.freebsd.org> From: Edward Tomasz Napierala Date: Thu, 3 Jun 2010 13:45:28 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r208781 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jun 2010 13:45:28 -0000 Author: trasz Date: Thu Jun 3 13:45:27 2010 New Revision: 208781 URL: http://svn.freebsd.org/changeset/base/208781 Log: The 'acl_cnt' field is unsigned; no point in checking if it's >= 0. Found with: Coverity Prevent CID: 3688 Modified: head/sys/kern/vfs_acl.c Modified: head/sys/kern/vfs_acl.c ============================================================================== --- head/sys/kern/vfs_acl.c Thu Jun 3 13:43:58 2010 (r208780) +++ head/sys/kern/vfs_acl.c Thu Jun 3 13:45:27 2010 (r208781) @@ -92,7 +92,7 @@ acl_copy_acl_into_oldacl(const struct ac { int i; - if (source->acl_cnt < 0 || source->acl_cnt > OLDACL_MAX_ENTRIES) + if (source->acl_cnt > OLDACL_MAX_ENTRIES) return (EINVAL); bzero(dest, sizeof(*dest));