Date: Tue, 25 Jan 2005 14:38:34 -0800 From: Kris Kennaway <kris@obsecurity.org> To: Tim Robbins <tjr@freebsd.org> Cc: freebsd-current@freebsd.org Subject: Re: uniq truncates lines > 2048 bytes Message-ID: <20050125223834.GA28389@xor.obsecurity.org> In-Reply-To: <20050125221047.GA339@cat.robbins.dropbear.id.au> References: <790a9fff05012509511b64e3ad@mail.gmail.com> <20050125221047.GA339@cat.robbins.dropbear.id.au>
next in thread | previous in thread | raw e-mail | index | archive | help
--vtzGhvizbBRQ85DL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 26, 2005 at 09:10:47AM +1100, Tim Robbins wrote: > On Tue, Jan 25, 2005 at 11:51:51AM -0600, Scot Hetzel wrote: > > I noticed that if a file has lines > 2048 bytes, uniq will truncate > > the line to LINE_MAX (2048 bytes). An easy way to test this is to do > > the following: > >=20 > > cd /usr/ports/accessibility/gnomemag > > make fetch-list > test.list > > make fetch-list >> test.list > > uniq test.list > test2.list > >=20 > > test2.list should be half the size of test.list, but it is 2048 bytes. > >=20 > > I have come up with a patch to uniq that fixes this problem. > >=20 > > http://www.freebsd.org/cgi/query-pr.cgi?pr=3D76578 >=20 > This looks good except for failure to check for realloc() returning NULL > and a few minor style problems. It may be possible to use fgetwln() > to read lines instead of getwc() + realloc() etc., but this function is > new and peculiar to FreeBSD. >=20 > I was planning on going through all text-processing utilities in the base > system some time and either fixing line length problems or documenting th= em, > similar to what I did with multibyte character support. I may make a start > at that today. If someone could fix comm(1) that would be a big help for me, because I have a local hack I have to carry around in all of my local package source trees. Kris --vtzGhvizbBRQ85DL Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) iD8DBQFB9spqWry0BWjoQKURArp7AJ9PwxRD/RL6KTQif4S5wBeXnV591QCghR5q oR7WpSUXuHAFfxWcs89oNOc= =funr -----END PGP SIGNATURE----- --vtzGhvizbBRQ85DL--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050125223834.GA28389>