Date: Tue, 11 Feb 2003 06:20:04 -0800 (PST) From: mistral@imasy.or.jp (Yoshihiko Sarumaru) To: freebsd-bugs@FreeBSD.org Subject: Re: bin/42574: YAMAHA RTW65b router coudn't be connected by umodem driver Message-ID: <200302111420.h1BEK4JL024371@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/42574; it has been noted by GNATS.
From: mistral@imasy.or.jp (Yoshihiko Sarumaru)
To: freebsd-gnats-submit@FreeBSD.org
Cc:
Subject: Re: bin/42574: YAMAHA RTW65b router coudn't be connected by umodem
driver
Date: Tue, 11 Feb 2003 23:10:33 +0900
It was coming out that bcdDevice of this product is depend on
the version of firmware, and my previous patch will loose its effect
when we upload the other firmware. So we must not use exact
bcdDevice but ANY keyword.
Also I had contacted with YAMAHA person and get three more models that
support USB serial and require the same approach to use with FreeBSD.
BTW, current implementation of usbd_find_quirk() seems does not
care `ANY' keyword although ANY keyword is already used, so my
new patch includes modification for usbd_find_quirk() too.
I wonder idProduct also should be ANY since new YAMAHA product
likely to require the same quirk, but it propagate this quirk to
not only umodem driver but also any USB drivers. I think this
quirk is not harmful for other USB products, but for the safety
I don't propose this way, now.
--- usbdevs.orig Tue Aug 27 22:46:28 2002
+++ usbdevs Sun Sep 15 20:45:05 2002
@@ -1099,6 +1099,10 @@
/* Yamaha products */
product YAMAHA UX256 0x1000 UX256 MIDI I/F
product YAMAHA UX96 0x1008 UX96 MIDI I/F
+product YAMAHA RTA54I 0x4000 NetVolante RTA54i Broadband&ISDN Router
+product YAMAHA RTA55I 0x4004 NetVolante RTA55i Broadband VoIP Router
+product YAMAHA RTW65B 0x4001 NetVolante RTW65b Broadband Wireless Router
+product YAMAHA RTW65I 0x4002 NetVolante RTW65i Broadband&ISDN Wireless Router
/* Yano products */
product YANO U640MO 0x0101 U640MO-03
--- usb_quirks.c.orig Sat Aug 24 17:00:32 2002
+++ usb_quirks.c Sun Sep 15 21:31:52 2002
@@ -77,6 +77,12 @@
0x100, { UQ_ASSUME_CM_OVER_DATA | UQ_NO_STRINGS }},
{ USB_VENDOR_ACERP, USB_PRODUCT_ACERP_ACERSCAN_320U,
0x000, { UQ_NO_STRINGS }},
+ /* YAMAHA router's ucdDevice is the version of farmware and often changes. */
+ { USB_VENDOR_YAMAHA, USB_PRODUCT_YAMAHA_RTA54I, ANY, { UQ_ASSUME_CM_OVER_DATA }},
+ { USB_VENDOR_YAMAHA, USB_PRODUCT_YAMAHA_RTA55I, ANY, { UQ_ASSUME_CM_OVER_DATA }},
+ { USB_VENDOR_YAMAHA, USB_PRODUCT_YAMAHA_RTW65B, ANY, { UQ_ASSUME_CM_OVER_DATA }},
+ { USB_VENDOR_YAMAHA, USB_PRODUCT_YAMAHA_RTW65I, ANY, { UQ_ASSUME_CM_OVER_DATA }},
+
/* XXX These should have a revision number, but I don't know what they are. */
{ USB_VENDOR_HP, USB_PRODUCT_HP_895C, ANY, { UQ_BROKEN_BIDIR }},
{ USB_VENDOR_HP, USB_PRODUCT_HP_880C, ANY, { UQ_BROKEN_BIDIR }},
@@ -97,7 +103,7 @@
for (t = usb_quirks; t->idVendor != 0; t++) {
if (t->idVendor == UGETW(d->idVendor) &&
t->idProduct == UGETW(d->idProduct) &&
- t->bcdDevice == UGETW(d->bcdDevice))
+ (t->bcdDevice == ANY || t->bcdDevice == UGETW(d->bcdDevice)))
break;
}
#ifdef USB_DEBUG
--
Yoshihiko Sarumaru
mail: mistral@imasy.or.jp web: http://www.imasy.or.jp/~mistral/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200302111420.h1BEK4JL024371>