Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 4 Jul 2013 13:42:09 -0600
From:      Warner Losh <imp@bsdimp.com>
To:        Jeroen Hofstee <freebsd_arm@myspectrum.nl>
Cc:        Alexander Motin <mav@FreeBSD.org>, Ilya Bakulin <ilya@bakulin.de>, freebsd-arm@freebsd.org, freebsd-embedded@freebsd.org
Subject:   Re: [PATCH] SDIO support for Globalscale Dreamplug
Message-ID:  <F74D77DE-826D-4CE2-A527-CCE58309D4EF@bsdimp.com>
In-Reply-To: <51D5B41A.5000805@myspectrum.nl>
References:  <20130702145905.GA1847@olymp.kibab.com> <51D3097A.8010601@FreeBSD.org> <51D3282C.1090701@bakulin.de> <C92CE8E1-75A0-459F-95DA-956D03DCB2E2@bsdimp.com> <20130703222002.GA60491@olymp.kibab.com> <51D50C55.1040300@myspectrum.nl> <16DEBC38-F99A-4733-86FD-9E81A146CE5C@bsdimp.com> <51D5B41A.5000805@myspectrum.nl>

next in thread | previous in thread | raw e-mail | index | archive | help

On Jul 4, 2013, at 11:42 AM, Jeroen Hofstee wrote:

> Hello Warner,
>=20
> On 07/04/2013 06:09 PM, Warner Losh wrote:
>> On Jul 3, 2013, at 11:47 PM, Jeroen Hofstee wrote:
>>=20
>>> Hello Ilya,
>>>=20
>>> On 07/04/2013 12:20 AM, Ilya Bakulin wrote:
>>>> So some bytes lack 0x40... This problem occurs also with other =
numbers
>>>> read from the card, for example, vendor ID is read as 0x029F =
instead of 0x02DF.
>>>> +/* Halfword bit masks used for command response extraction. */
>>>> +#define MV_SDIO_RSP48_BM2	0x0002	/* Lower 2 bits. */
>>>> +#define MV_SDIO_RSP48_BM6	0x003f	/* Lower 6 bits. */
>>>> +	/* Response bits [15:14] and [13:8] */
>>>> +	*rp++ =3D (resp[2] & MV_SDIO_RSP48_BM6) |
>>>> +	    ((word & MV_SDIO_RSP48_BM2) << 6);
>>>> +
>>> =46rom the looks if it, MV_SDIO_RSP48_BM2 must be 3 instead 2.
>> And 0x0031 doesn't look right either... I'd have expected 0x3f.
> which 0x0031 (perhaps I need to have my eyes checked....)?

No, my eyes.

Warner




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F74D77DE-826D-4CE2-A527-CCE58309D4EF>